From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0DEE7198005 for ; Sun, 24 Feb 2013 18:56:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 92292E079B; Sun, 24 Feb 2013 18:56:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 86EA9E0793 for ; Sun, 24 Feb 2013 18:55:59 +0000 (UTC) Received: from pomiocik.lan (unknown [213.195.173.220]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id A1D8F33D3D4; Sun, 24 Feb 2013 18:55:57 +0000 (UTC) Date: Sun, 24 Feb 2013 19:56:12 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: ssuominen@gentoo.org Subject: Re: [gentoo-dev] New eclass: autotools-multilib-minimal Message-ID: <20130224195612.01a7e528@pomiocik.lan> In-Reply-To: <512A46A0.6050007@gentoo.org> References: <51296027.705@gentoo.org> <51299593.1010902@gentoo.org> <20130224155715.428b0493@pomiocik.lan> <1361718738.20067.54.camel@belkin4> <20130224165302.7470cb1b@pomiocik.lan> <512A46A0.6050007@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.16; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/n1Aojy_GqEJrVz9L0r.rbed"; protocol="application/pgp-signature" X-Archives-Salt: 3c47b367-761a-408a-baef-ef42be234a6e X-Archives-Hash: 95393053a5f4b1b3766cdba360b4461f --Sig_/n1Aojy_GqEJrVz9L0r.rbed Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 24 Feb 2013 18:58:08 +0200 Samuli Suominen wrote: > On 24/02/13 17:53, Micha=C5=82 G=C3=B3rny wrote: > >> I still try to use plain ebuilds without > >> inheritting autotools-utils.eclass as I usually don't need it, probably > >> others do the same and refuse to have to inherit it only for multilib > >> support :/ How do you plan to solve this problem? > > > > You generally have two options on doing multilib builds: either using > > out-of-source builds or in-source builds. If you decide on the latter, > > you unnecessarily waste users' time and disk space to create two more > > copies of sources. I don't think we should go this way. > > > > If you decide on out-of-source builds, you basically need proper > > src_{configure,compile,test,install} and that's what autotools-utils > > does. Plus: > > > > - patch applying and autoreconf in src_prepare() -- which are > > completely optional, you are free to write your own src_prepare(). > > If you wanted to apply patches by hand, you'd need to write > > src_prepare() anyway. >=20 > It's that "Plus" part that is my problem with autotools-multilib.eclass=20 > currently, it adds EXPORT_FUNCTIONS of src_prepare() from=20 > autotools-utils.eclass which is irrelevant to the autotools-multilib.ecla= ss > adds just another eclass/phase function to worry about for inherit order I understand your concern but I see no way around it. The alternative solution exports src_prepare() as well to copy the sources -- so it's even more to worry about than the no-op-by-default. > > - prune_libtool_files in src_install() which most people want to do > > anyway, so that doesn't hurt -- and the pkg-config dep is going to > > be removed, by the patch I sent already. >=20 > but lacks a way to pass arguments to prune_libtool_files, like --all,=20 > since prune_libtool_files isn't that smart it gets it right everytime > i propably prefer to stick to manually calling it with or without --all > and well, this is not related to the multilib conversion so it shouldn't= =20 > be executed anyway I can add the ability to pass arguments. So far, hasn't considered it necessary since the single run doesn't really hurt anything noticeably. > > - adding libtool args for shared/static libs if IUSE=3Dstatic-libs -- > > which I wanted to remove but people considered it useful. >=20 > if it's not related to the multilib conversion, it shouldn't be executed.= .. It's not about multilib conversion solely. Multilib conversion requires out-of-source build support. Out-of-source build support is established using autotools-utils. The logical conversion order is to: 1) convert the ebuild to autotools-utils, make sure that out-of-source builds work, 2) convert the ebuild to autotools-multilib. Some of my conversions actually follow that split, providing two patches instead of one. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/n1Aojy_GqEJrVz9L0r.rbed Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRKmJNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKt0sP+wUgtxZlSe9ujyNySrKnB36r acXVjOZy1H5BMkHJpmTwre5klg6LDds/JMyTe8GlwWY4r2VuQHZTFgg/j8pJ12d1 LTweZW+tHo87Tk3TyCEyrQCPftoTdN9XZWQoqukoFaTgHxcR3xtrxYTPubocfhbF +XKqlLMdyBGhsB6+J7ycwqDcKqQqSbKKw8HhLj9nXi0NLZQgL9KTMSFPOsQf8Y7k KO1fx/a8dhE5cOYUEXTRw2qbzs3hkF2KX78embpFY4x+vWzp529eCFfVhY54kQQ3 6w3CQIOYhUVXYphE16ySUB50G6n09ge9179YQL9wjFARatweEVLyJQNF0ucY6+E7 VTpS3/1d1ZOiYsGSYeWxRj/oJiQf6vayLzgXBVlTJQeMSEuLQQWKw1IwlVmMmxT9 EVaSUiUsKy24B151f1NEX1qJ7N0YmVrmioInuQ+0X5z2+G0ktHLVXtArom+B4zTG qPQd75GKl9lPMlWR6sbu2ZTHEePpS/2IRZvNjenWeDH25rmIk8icECRZtpeIa4/P 0vvjPBm10wf+zSuuXj44CfphPD3Ma+JqYqDql3/CiOSNXIpiC+E6LxR8Lw1m6DNz ChZeFFdfeq9SR60dvlZOXTWmHpS5oyFKejyeTDYzGAAFy3PCusdNxzeO16roNrxM SGR8prpTfEfWPqQ+9mrP =k6uF -----END PGP SIGNATURE----- --Sig_/n1Aojy_GqEJrVz9L0r.rbed--