From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: tommy@gentoo.org
Subject: Re: [gentoo-dev] [PATCH eutils] prune_libtool_files: make pkg-config optional, add a sed fallback.
Date: Fri, 22 Feb 2013 21:51:31 +0100 [thread overview]
Message-ID: <20130222215131.00b397a2@pomiocik.lan> (raw)
In-Reply-To: <5127CB31.1090609@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Fri, 22 Feb 2013 20:46:57 +0100
Thomas Sachau <tommy@gentoo.org> wrote:
> Michał Górny schrieb:
> > ---
> > gx86/eclass/eutils.eclass | 33 +++++++++++++++++++++++++--------
> > 1 file changed, 25 insertions(+), 8 deletions(-)
> >
> > diff --git a/gx86/eclass/eutils.eclass b/gx86/eclass/eutils.eclass
> > index f662041..a8bf512 100644
> > --- a/gx86/eclass/eutils.eclass
> > +++ b/gx86/eclass/eutils.eclass
> > @@ -1407,8 +1407,9 @@ fi
> > # that they should not be linked to, i.e. whenever these files
> > # correspond to plugins.
> > #
> > -# Note: if your package installs both static libraries and .pc files,
> > -# you need to add pkg-config to your DEPEND.
> > +# Note: if your package installs both static libraries and .pc files
> > +# which use variable substitution for -l flags, you need to add
> > +# pkg-config to your DEPEND.
> > prune_libtool_files() {
> > debug-print-function ${FUNCNAME} "$@"
> >
> > @@ -1470,14 +1471,30 @@ prune_libtool_files() {
> > if [[ ! ${removing_all} ]]; then
> > local pc
> > local tf=${T}/prune-lt-files.pc
> > - local pkgconf=$(tc-getPKG_CONFIG)
> > + local pkgconf=$(tc-getPKG_CONFIG)1
>
> Typo?
Ah, thanks for catching it.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]
next prev parent reply other threads:[~2013-02-22 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 16:04 [gentoo-dev] [PATCH eutils] prune_libtool_files: make pkg-config optional, add a sed fallback Michał Górny
2013-02-22 19:46 ` Thomas Sachau
2013-02-22 20:51 ` Michał Górny [this message]
2013-02-22 20:51 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222215131.00b397a2@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=tommy@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox