From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-58237-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id A086713889A
	for <garchives@archives.gentoo.org>; Wed,  6 Feb 2013 01:33:14 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id DC234E049A;
	Wed,  6 Feb 2013 01:33:10 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id EB381E003C
	for <gentoo-dev@lists.gentoo.org>; Wed,  6 Feb 2013 01:33:09 +0000 (UTC)
Received: from localhost (pc-234-79-101-190.cm.vtr.net [190.101.79.234])
	(using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: aballier)
	by smtp.gentoo.org (Postfix) with ESMTPSA id DEA4D33DF7C
	for <gentoo-dev@lists.gentoo.org>; Wed,  6 Feb 2013 01:33:07 +0000 (UTC)
Date: Tue, 5 Feb 2013 22:32:59 -0300
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] Introduce cmake-multilib wrapper for
 cmake-utils.
Message-ID: <20130205223259.68e4c0c1@gentoo.org>
In-Reply-To: <1360095564-18154-3-git-send-email-mgorny@gentoo.org>
References: <1360095564-18154-1-git-send-email-mgorny@gentoo.org>
	<1360095564-18154-3-git-send-email-mgorny@gentoo.org>
Organization: Gentoo
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: c49ae12e-6099-4f3a-af31-d5a49cf07f7b
X-Archives-Hash: 7be27e4b34e32efad7568de137426dae

On Tue,  5 Feb 2013 21:19:23 +0100
Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org> wrote:

> +cmake-multilib_src_install() {
> +	cmake-multilib_secure_install() {
> +		cmake-utils_src_install
> +
> +		# Make sure all headers are the same for each ABI.
> +		cmake-multilib_cksum() {
> +			find "${ED}"usr/include -type f \
> +				-exec cksum {} + | sort -k2
> +		}
> +
> +		local cksum=3D$(cmake-multilib_cksum)
> +		local cksum_file=3D${T}/.cmake-multilib_cksum
> +
> +		if [[ -f ${cksum_file} ]]; then
> +			local cksum_prev=3D$(< "${cksum_file}")
> +
> +			if [[ ${cksum} !=3D ${cksum_prev} ]]; then
> +				echo "${cksum}" > "${cksum_file}.new"
> +
> +				eerror "Header files have changed
> between ABIs." +
> +				if type -p diff &>/dev/null; then
> +					eerror "$(diff -du
> "${cksum_file}" "${cksum_file}.new")"
> +				else
> +					eerror "Old checksums in:
> ${cksum_file}"
> +					eerror "New checksums in:
> ${cksum_file}.new"
> +				fi
> +
> +				die "Header checksum mismatch,
> aborting."
> +			fi
> +		else
> +			echo "${cksum}" > "${cksum_file}"
> +		fi
> +	}

> The eclass uses the same header consistency check as
> autotools-multilib
> (therefore, I move the function to multilib-build).


You probably forgot to use it here