public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] Introduce cmake-multilib wrapper for cmake-utils.
Date: Tue, 5 Feb 2013 22:32:59 -0300	[thread overview]
Message-ID: <20130205223259.68e4c0c1@gentoo.org> (raw)
In-Reply-To: <1360095564-18154-3-git-send-email-mgorny@gentoo.org>

On Tue,  5 Feb 2013 21:19:23 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> +cmake-multilib_src_install() {
> +	cmake-multilib_secure_install() {
> +		cmake-utils_src_install
> +
> +		# Make sure all headers are the same for each ABI.
> +		cmake-multilib_cksum() {
> +			find "${ED}"usr/include -type f \
> +				-exec cksum {} + | sort -k2
> +		}
> +
> +		local cksum=$(cmake-multilib_cksum)
> +		local cksum_file=${T}/.cmake-multilib_cksum
> +
> +		if [[ -f ${cksum_file} ]]; then
> +			local cksum_prev=$(< "${cksum_file}")
> +
> +			if [[ ${cksum} != ${cksum_prev} ]]; then
> +				echo "${cksum}" > "${cksum_file}.new"
> +
> +				eerror "Header files have changed
> between ABIs." +
> +				if type -p diff &>/dev/null; then
> +					eerror "$(diff -du
> "${cksum_file}" "${cksum_file}.new")"
> +				else
> +					eerror "Old checksums in:
> ${cksum_file}"
> +					eerror "New checksums in:
> ${cksum_file}.new"
> +				fi
> +
> +				die "Header checksum mismatch,
> aborting."
> +			fi
> +		else
> +			echo "${cksum}" > "${cksum_file}"
> +		fi
> +	}

> The eclass uses the same header consistency check as
> autotools-multilib
> (therefore, I move the function to multilib-build).


You probably forgot to use it here


  reply	other threads:[~2013-02-06  1:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 20:19 [gentoo-dev] New eclass: cmake-multilib for cmake multilib package builds Michał Górny
2013-02-05 20:19 ` [gentoo-dev] [PATCH 1/3] Move header consistency checking func into multilib-build Michał Górny
2013-02-05 20:19 ` [gentoo-dev] [PATCH 2/3] Introduce cmake-multilib wrapper for cmake-utils Michał Górny
2013-02-06  1:32   ` Alexis Ballier [this message]
2013-02-06  9:56     ` Michał Górny
2013-02-06 10:02       ` [gentoo-dev] [PATCH] " Michał Górny
2013-04-13  1:04         ` Pass "${@}" in phase functions " Michael Weber
2013-04-13 15:50           ` Michał Górny
2013-04-13 19:15             ` Michael Weber
2013-04-13 16:00           ` [gentoo-dev] Re: Pass "${@}" in phase functions " Steven J. Long
2013-04-13 16:47           ` Pass "${@}" in phase functions Re: [gentoo-dev] " Ciaran McCreesh
2013-02-05 20:19 ` [gentoo-dev] [PATCH 3/3] Convert virtualgl to cmake-multilib Michał Górny
2013-02-06  1:35   ` Alexis Ballier
2013-02-06 10:07     ` [gentoo-dev] [PATCH] " Michał Górny
2013-02-06 14:02       ` Alexis Ballier
2013-02-06 14:09         ` Michał Górny
2013-02-07 23:08   ` [gentoo-dev] Re: [PATCH 3/3] " Maciej Mrozowski
2013-02-07  8:36 ` [gentoo-dev] New eclass: cmake-multilib for cmake multilib package builds Ben de Groot
2013-02-07  8:38   ` Ben de Groot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130205223259.68e4c0c1@gentoo.org \
    --to=aballier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox