From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 643FA13881B for ; Sun, 3 Feb 2013 08:16:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4902A21C020; Sun, 3 Feb 2013 08:16:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2081721C014 for ; Sun, 3 Feb 2013 08:16:38 +0000 (UTC) Received: from sera-20.lan (9-54.105-92.cust.bluewin.ch [92.105.54.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sera) by smtp.gentoo.org (Postfix) with ESMTPSA id B9B7C33DD15 for ; Sun, 3 Feb 2013 08:16:36 +0000 (UTC) Date: Sun, 3 Feb 2013 09:20:44 +0100 From: Ralph Sennhauser To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT Message-ID: <20130203092044.7dbacd91@sera-20.lan> In-Reply-To: <20130202233325.GA4159@gengoff.local.grandmasfridge.org> References: <20130202233325.GA4159@gengoff.local.grandmasfridge.org> Organization: Gentoo Linux X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.12; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/LdZFCAwYGz/JL1f7gzl1Sye"; protocol="application/pgp-signature" X-Archives-Salt: bef51894-bd2f-40d2-af52-c202ea06f128 X-Archives-Hash: 1ba163bb0cc2de99dcd271f80bfeb8fc --Sig_/LdZFCAwYGz/JL1f7gzl1Sye Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 2 Feb 2013 23:33:26 +0000 "Aaron W. Swenson" wrote: > After years of "if use test ; then ..." just working when > FEATURES=3D"test" is declared, it isn't working with EAPI5. I think we > could save some bytes and headaches if we just add "test" to > IUSE_IMPLICIT. >=20 > Portage's emerge's "--newuse" option won't be affected by this. From > `man emerge`: > > NOTE: This option ignores the state of the "test" USE flag, since > > that flag has a special binding to FEATURES=3D"test" (see make.conf(5) > > for more information about FEATURES settings). >=20 > What say you? >=20 That test shouldn't be a useflag in the first place, that there should be a TESTDEPEND and a dedicatated function defined in PMS to let the ebuild check if src_test will be executed. 'test' as we use it is pretty much a hack. Another note, 'if use test; then' is often very similar in nature to conditional patching and should be avoided where reasonably possible. Either way, I'm against adding test to IMPLICIT_IUSE on the basis of 'I was lazy and want to continue to do so'. Regards Ralph --Sig_/LdZFCAwYGz/JL1f7gzl1Sye Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJRDh3jAAoJELjwI6Q8XPdae6sH/iQQQojWXHOxHjttzHTuBhrx Q7J7AbMyKARPcMAkt/NrMVPt+PboNjWcishypnBzCxUBKAMkjy/pxc1YdmxHzSeI vEpRyDF4N26EU0u5h/Qs8ETIuNH+UZRsrnTsdsLqF8wraWaDcu2zOboyJ3H601t+ v6ebwxIaQqj2uSoxCkRF2irCXWIta9RTgFPSO+zO9dAi1yj6BzjoYAvI2m8LIreC NxyhIIfWj6OTc1Zz5W3FsbEGzQKy9aIxuSrWYLSiZCwcB+rusEJf9DumC9zqdMOl /Ewteb7fD5HCDqBcGrln7m/7zb+YJM52eblElgZ+zL2qYQ4CHYDCFu4SnNtD8EM= =eR7C -----END PGP SIGNATURE----- --Sig_/LdZFCAwYGz/JL1f7gzl1Sye--