[gentoo-dev] Add "test" to IUSE_IMPLICIT

[gentoo-dev] Add "test" to IUSE_IMPLICIT

[Aaron W. Swenson]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

After years of "if use test ; then ..." just working when
FEATURES="test" is declared, it isn't working with EAPI5. I think we
could save some bytes and headaches if we just add "test" to
IUSE_IMPLICIT.

Portage's emerge's "--newuse" option won't be affected by this. From
`man emerge`:
> NOTE: This option ignores the state of the "test" USE flag, since
> that flag has a special binding to FEATURES="test" (see make.conf(5)
> for more information about FEATURES settings).

What say you?

-- 
Mr. Aaron W. Swenson
Gentoo Linux Developer
Email : titanofold@gentoo.org
GnuPG FP : 2C00 7719 4F85 FB07 A49C 0E31 5713 AA03 D1BB FDA0
GnuPG ID : D1BBFDA0

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Sat, 2 Feb 2013 23:33:26 +0000
"Aaron W. Swenson" <titanofold@gentoo.org> wrote:

> After years of "if use test ; then ..." just working when
> FEATURES="test" is declared, it isn't working with EAPI5.

You shouldn't admit that for years you didn't knew that this was
incorrect and you should have been using IUSE=test.

> I think we could save some bytes and headaches if we just add "test"
> to IUSE_IMPLICIT.

First of all, you should note that you will still need to add IUSE=test
to pre-EAPI 5 ebuilds.

Secondly, what about all the ebuilds which declare IUSE=test in EAPI 5?
Shall we remove that value from IUSE? Keep it?

What will be the impact on metadata? It seems that the PMS allows
dependencies on IUSE_EFFECTIVE, so we can basically have dependencies
with flags which are valid only on some of the profiles...

> Portage's emerge's "--newuse" option won't be affected by this. From
> `man emerge`:
> > NOTE: This option ignores the state of the "test" USE flag, since
> > that flag has a special binding to FEATURES="test" (see make.conf(5)
> > for more information about FEATURES settings).
> 
> What say you?

I say that putting semi-automatic, dynamically changing flag
into IUSE_IMPLICIT is a bad idea. Right now, we just keep the things
that are really not supposed to change there.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

On Sun, 3 Feb 2013 00:50:02 +0100
Michał Górny <mgorny@gentoo.org> wrote:
> What will be the impact on metadata? It seems that the PMS allows
> dependencies on IUSE_EFFECTIVE, so we can basically have dependencies
> with flags which are valid only on some of the profiles...

I don't get it. Be more specific as to how it's an issue from the spec
side please.

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT

[Aaron W. Swenson]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

On Sun, Feb 03, 2013 at 12:50:02AM +0100, Michał Górny wrote:
> On Sat, 2 Feb 2013 23:33:26 +0000
> "Aaron W. Swenson" <titanofold@gentoo.org> wrote:
> 
> > After years of "if use test ; then ..." just working when
> > FEATURES="test" is declared, it isn't working with EAPI5.
> 
> You shouldn't admit that for years you didn't knew that this was
> incorrect and you should have been using IUSE=test.

Let me rephrase that: Experience led me to 'FEATURE="test"' implies
'USE="test"' regardless of whether "test" is in IUSE or not.

Further, if I'm adding FEATURE="test", why wouldn't I also want
USE="test".

> > I think we could save some bytes and headaches if we just add "test"
> > to IUSE_IMPLICIT.
> 
> First of all, you should note that you will still need to add IUSE=test
> to pre-EAPI 5 ebuilds.

Not need. Apparently supposed to have done that, though. As I said, it
has been working without it for years and only stopped when I used EAPI5.

> Secondly, what about all the ebuilds which declare IUSE=test in EAPI 5?
> Shall we remove that value from IUSE? Keep it?
> 

"test" being in IUSE becomes moot. It wouldn't much matter whether
it's there or it isn't.

> What will be the impact on metadata? It seems that the PMS allows
> dependencies on IUSE_EFFECTIVE, so we can basically have dependencies
> with flags which are valid only on some of the profiles...

IUSE_EFFECTIVE is probably better.

-- 
Mr. Aaron W. Swenson
Gentoo Linux Developer
Email : titanofold@gentoo.org
GnuPG FP : 2C00 7719 4F85 FB07 A49C 0E31 5713 AA03 D1BB FDA0
GnuPG ID : D1BBFDA0

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT

[Ian Stakenvicius]

On 2013-02-02, at 6:50 PM, Michał Górny <mgorny@gentoo.org> wrote:

> On Sat, 2 Feb 2013 23:33:26 +0000
> "Aaron W. Swenson" <titanofold@gentoo.org> wrote:.
> 
> First of all, you should note that you will still need to add IUSE=test
> to pre-EAPI 5 ebuilds.
> 
> Secondly, what about all the ebuilds which declare IUSE=test in EAPI 5?
> Shall we remove that value from IUSE? Keep it?

drop it, and maybe we would need to RESTRICT="test" on all ebuilds that don't support testing? ( dunno )

[gentoo-dev] Re: Add "test" to IUSE_IMPLICIT

[Ryan Hill]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

On Sat, 2 Feb 2013 23:33:26 +0000
"Aaron W. Swenson" <titanofold@gentoo.org> wrote:

> After years of "if use test ; then ..." just working when
> FEATURES="test" is declared, it isn't working with EAPI5.

I would say that's a bug fix.  If you're checking if a USE flag is set then it
had better be in IUSE.


-- 
gcc-porting
toolchain, wxwidgets            learn a language baby, it's that kind of place
@ gentoo.org                   where low card is hunger and high card is taste

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] Add "test" to IUSE_IMPLICIT

[Ralph Sennhauser]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On Sat, 2 Feb 2013 23:33:26 +0000
"Aaron W. Swenson" <titanofold@gentoo.org> wrote:

> After years of "if use test ; then ..." just working when
> FEATURES="test" is declared, it isn't working with EAPI5. I think we
> could save some bytes and headaches if we just add "test" to
> IUSE_IMPLICIT.
> 
> Portage's emerge's "--newuse" option won't be affected by this. From
> `man emerge`:
> > NOTE: This option ignores the state of the "test" USE flag, since
> > that flag has a special binding to FEATURES="test" (see make.conf(5)
> > for more information about FEATURES settings).
> 
> What say you?
> 

That test shouldn't be a useflag in the first place, that there should
be a TESTDEPEND and a dedicatated function defined in PMS to let the
ebuild check if src_test will be executed. 'test' as we use it is
pretty much a hack.

Another note, 'if use test; then' is often very similar in nature to
conditional patching and should be avoided where reasonably possible.


Either way, I'm against adding test to IMPLICIT_IUSE on the basis of 'I
was lazy and want to continue to do so'.

Regards
Ralph

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]