From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4B08E13877C for ; Thu, 31 Jan 2013 00:07:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 124ED21C02F; Thu, 31 Jan 2013 00:07:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2682CE04BA for ; Thu, 31 Jan 2013 00:07:14 +0000 (UTC) Received: from caribou.gateway.2wire.net (71-17-69-121.yktn.hsdb.sasknet.sk.ca [71.17.69.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: dirtyepic) by smtp.gentoo.org (Postfix) with ESMTPSA id 2309833DBF0 for ; Thu, 31 Jan 2013 00:07:13 +0000 (UTC) Date: Wed, 30 Jan 2013 18:17:46 -0600 From: Ryan Hill To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [PATCH eutils] Die if epunt_cxx is called unnecessarily. Message-ID: <20130130181746.01bbbb1e@caribou.gateway.2wire.net> In-Reply-To: <20130131005306.4d9a9c71@pomiocik.lan> References: <1359581813-1973-1-git-send-email-mgorny@gentoo.org> <20130130175720.24c2e426@caribou.gateway.2wire.net> <20130131005306.4d9a9c71@pomiocik.lan> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Hu1lEOqTKale4TY4/HOL8Vd"; protocol="application/pgp-signature" X-Archives-Salt: f37db2a7-4fbe-4e3e-b635-6999aeef2968 X-Archives-Hash: 62cceebd0c90d443a404f76a3af847cf --Sig_/Hu1lEOqTKale4TY4/HOL8Vd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 31 Jan 2013 00:53:06 +0100 Micha=C5=82 G=C3=B3rny wrote: > On Wed, 30 Jan 2013 17:57:20 -0600 > Ryan Hill wrote: > > On Wed, 30 Jan 2013 22:36:53 +0100 > > Micha=C5=82 G=C3=B3rny wrote: > > > Currently, epunt_cxx always succeeds. This results in some > > > of the ebuilds keeping its use even though the C++ checks were removed > > > upstream. > > >=20 > > > Therefore, I'm suggesting to add a simple check to the function -- if > > > none of the patching attempts succeed, die requesting the user to rem= ove > > > the invocation. > >=20 > > eqawarn? >=20 > Yes, eqawarn if we don't want users to be hurt :P. I think it would be overkill to make what is essentially a no-op into a fat= al error. A warning would be appropriate. --=20 gcc-porting toolchain, wxwidgets learn a language baby, it's that kind of pl= ace @ gentoo.org where low card is hunger and high card is ta= ste --Sig_/Hu1lEOqTKale4TY4/HOL8Vd Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJRCbgvAAoJEO04vUmVeoRjOJsH/2PjOUjATK7jmBEGF7r/nY3L +pKYHTnhFasBBeyL2EjYU2WKWE2mO/Ll6wzUm6+VeuFHlLyxJAVshrgLXotg1bza YIxI9LML1rneJ2huWJX67w4hYOSQ2s93Ku1Vz1uPZVyypLSfSR32hzEHkF6MPlJT NUB+gjbmRN5hTxr2lUR++x2v2T4vllR+jZaqzKHyZsrdvpx7PfYCbAnFevx+JxC1 YPibeFeltlcsp8+slulCdWcMndEGJaPuW9kAfT8aUL8wpIiEw43op1KKAxd2tKoa 5LdfH8gnckllcP2Xma5qmtohnlQNJUIkSPxM6a0lfvOqYystm9y3PBeULhnXP2M= =DIHS -----END PGP SIGNATURE----- --Sig_/Hu1lEOqTKale4TY4/HOL8Vd--