From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-58032-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 16C431386F0
	for <garchives@archives.gentoo.org>; Sun, 27 Jan 2013 23:27:21 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 0E0B721C04B;
	Sun, 27 Jan 2013 23:27:16 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 06AB221C00C
	for <gentoo-dev@lists.gentoo.org>; Sun, 27 Jan 2013 23:27:14 +0000 (UTC)
Received: from localhost (pc-234-79-101-190.cm.vtr.net [190.101.79.234])
	(using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: aballier)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 6D05033DA71;
	Sun, 27 Jan 2013 23:27:12 +0000 (UTC)
Date: Sun, 27 Jan 2013 20:27:06 -0300
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: mgorny@gentoo.org, amd64@gentoo.org, releng@gentoo.org, x11@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select
 multilib targets.
Message-ID: <20130127202706.796544e6@gentoo.org>
In-Reply-To: <1359326768-4342-1-git-send-email-mgorny@gentoo.org>
References: <20130127093413.6919d22b@gentoo.org>
	<1359326768-4342-1-git-send-email-mgorny@gentoo.org>
Organization: Gentoo
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 3748b45c-acd2-40d5-bf9b-3f1fff190b84
X-Archives-Hash: 4984eeb062b216362fd7989f5a14296f

On Sun, 27 Jan 2013 23:46:06 +0100
Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org> wrote:

> Alexis,
>=20
> Following your remark, I have redesigned the loop to use MULTILIB_ABIS
> list to order the ABIs. This should ensure the most valid replacement
> order.

Great, that's better than what I had thought about

> Additionally, I have added an assertion to ensure that DEFAULT_ABI
> comes last in MULTILIB_ABIS list.

I'm not sure it is a good idea: it is certainly safe, but this removes
the flexibility not to build for the DEFAULT_ABI. Not sure if it's
sane to do so or if there is any usecase either, but since get_all_abis
ensures us DEFAULT_ABI is last I don't see a need to double check it
here.

Alexis.