Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Sun, 27 Jan 2013 09:34:13 -0300
Alexis Ballier <aballier@gentoo.org> wrote:

> Very nice work; +1 on everything, it seems we'll finally get serious
> and official multilib support after all those years.
> I'm looking forward to get this in three :)

I am writing some kind of spec/summary right now.

> On Sat, 26 Jan 2013 23:08:13 +0100
> Michał Górny <mgorny@gentoo.org> wrote:
> [...]
> >  # @FUNCTION: multilib_get_enabled_abis
> >  # @DESCRIPTION:
> > @@ -49,9 +64,20 @@ MULTILIB_USEDEP='multilib(-)?'
> >  multilib_get_enabled_abis() {
> >  	debug-print-function ${FUNCNAME} "${@}"
> >  
> > -	if use multilib; then
> > -		get_all_abis
> > -	else
> > +	local supported_abis=$(get_all_abis)
> > +	local i found
> > +	for i in "${_MULTILIB_FLAGS[@]}"; do
> > +		local abi=${i#*:}
> > +		local flag=${i%:*}
> > +
> > +		if has "${abi}" ${supported_abis} && use "${flag}";
> > then
> > +			echo "${abi}"
> > +			found=1
> > +		fi
> > +	done
> > +
> > +	if [[ ! ${found} ]]; then
> > +		debug-print "${FUNCNAME}: no ABIs enabled, fallback
> > to ${DEFAULT_ABI}" echo ${DEFAULT_ABI}
> >  	fi
> >  }
> 
> Just one thing here: I may have missed something, but how do you ensure
> the DEFAULT_ABI is last in the list ? It seems to me you rely on the
> order of _MULTILIB_FLAGS. I'd just skip it explicitly (if the
> corresponding useflag is enabled) and print DEFAULT_ABI at the end to be
> on the safe side, if it has been skipped.

That seems like a reasonable idea. I'd have a second and third look
at the function, and see if it wouldn't be better to just iterate over
$(get_all_abis) in the outer loop.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]