From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: vapier@gentoo.org, constanze@gentoo.org
Subject: Re: [gentoo-dev] fcaps.eclass: bringing filesystem capabilities to the tree
Date: Sat, 26 Jan 2013 14:21:37 +0100 [thread overview]
Message-ID: <20130126142137.1f2a728c@pomiocik.lan> (raw)
In-Reply-To: <201301251851.45021.vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Fri, 25 Jan 2013 18:51:44 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> # Or set it via the global ebuild var FILECAPS:
> # @CODE
> # FILECAPS=(
> # cap_net_raw bin/ping bin/ping6
> # )
> # @CODE
Please don't. We have enough eclasses randomly exporting
pkg_postinst().
The FILECAPS array consumes the same amount of space as pkg_postinst()
phase declaration. There's no real benefit to this automagic.
Yet, the phase function exported is *forced* to every single eclass
consumer. Therefore, you are implicitly adding lines for people who
will have to make sure that every single other pkg_postinst() you
clobbered is called.
Of course, assuming people would actually notice some of the other
useless pkg_postinst() phases being clobbered...
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
next prev parent reply other threads:[~2013-01-26 13:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 23:51 [gentoo-dev] fcaps.eclass: bringing filesystem capabilities to the tree Mike Frysinger
2013-01-26 0:10 ` Gilles Dartiguelongue
2013-01-26 0:17 ` Diego Elio Pettenò
2013-01-26 7:46 ` Mike Frysinger
2013-01-26 10:17 ` [gentoo-dev] " Duncan
2013-01-26 16:01 ` [gentoo-dev] " Diego Elio Pettenò
2013-01-26 16:13 ` Rich Freeman
2013-01-26 17:02 ` Diego Elio Pettenò
2013-01-28 19:58 ` Gilles Dartiguelongue
2013-01-26 13:21 ` Michał Górny [this message]
2013-01-26 17:08 ` Mike Frysinger
2013-01-26 21:07 ` Doug Goldstein
2013-01-27 17:26 ` Mike Frysinger
2013-01-27 18:24 ` Kacper Kowalik
2013-01-29 12:14 ` [gentoo-dev] " Duncan
2013-01-30 0:47 ` Diego Elio Pettenò
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126142137.1f2a728c@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=constanze@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox