From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: kingtaco@gentoo.org, amd64@gentoo.org, devrel@gentoo.org, x11@gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH 2/2] Use new multilib flags in autotools-multilib.
Date: Thu, 24 Jan 2013 22:15:33 +0100 [thread overview]
Message-ID: <20130124221533.64f5d8a9@pomiocik.lan> (raw)
In-Reply-To: <51016E9C.4030508@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Thu, 24 Jan 2013 09:25:48 -0800
Mike Doty <kingtaco@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01/23/13 15:23, Michał Górny wrote:
> > This is mostly a proof-of-concept. If approved, I will work on moving
> > the code into a separate eclass, possibly named 'multilib-build' ;).
> > ---
> > gx86/eclass/autotools-multilib.eclass | 24 +++++++++++++++++++++---
> > 1 file changed, 21 insertions(+), 3 deletions(-)
> >
> > diff --git a/gx86/eclass/autotools-multilib.eclass b/gx86/eclass/autotools-multilib.eclass
> > index 7c8697a..eef7bcc 100644
> > --- a/gx86/eclass/autotools-multilib.eclass
> > +++ b/gx86/eclass/autotools-multilib.eclass
> > @@ -32,7 +32,23 @@ inherit autotools-utils multilib
> >
> > EXPORT_FUNCTIONS src_configure src_compile src_test src_install
> >
> > -IUSE=multilib
> > +# Declare all of them, profiles will control their visibility.
> > +IUSE='abi_x86_32 abi_x86_64'
> > +
> > +# @FUNCTION: _autotools-multilib_get_enabled_abis
> > +# @DESCRIPTION:
> > +# Get the list of enabled ABIs. The returned names are suitable for use
> > +# with multilib.eclass.
> > +#
> > +# If multilib is not enabled or not supported, returns an empty list.
> > +_autotools-multilib_get_enabled_abis() {
> > + debug-print-function ${FUNCNAME} "${@}"
> > +
> > + if use amd64; then
> > + use abi_x86_64 && echo amd64
> > + use abi_x86_32 && echo x86
> > + fi
> > +}
> >
> > # @FUNCTION: autotools-multilib_foreach_abi
> > # @USAGE: argv...
> > @@ -46,9 +62,11 @@ IUSE=multilib
> > autotools-multilib_foreach_abi() {
> > local initial_dir=${BUILD_DIR:-${S}}
> >
> > - if use multilib; then
> > + local multilib_abis=$(_autotools-multilib_get_enabled_abis)
> > +
> > + if [[ ${multilib_abis} ]]; then
> > local ABI
> > - for ABI in $(get_all_abis); do
> > + for ABI in ${multilib_abis}; do
> > multilib_toolchain_setup "${ABI}"
> > BUILD_DIR=${initial_dir%%/}-${ABI} "${@}"
> > done
> >
> Why CC devrel on this?
Oops, sorry. I meant to CC releng...
- --
Best regards,
Michał Górny
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
iJwEAQEIAAYFAlEBpHoACgkQfXuS5UK5QB2znQP/YTR6zos9ATcaXSjoo1+bhiVl
tSpvNXGDRmYEIVGWdW7831oTd1/5bazGaoALnC5Y8iURblI8MUENv7xx4u9RQnQb
okIKHLXWFsirMrx3XAs0nTbRotZxFZY00N93mhYHYGjg4l0bnsIVCQC6dBpHLKRX
wMUEF2WjATT0ACxgyos=
=qTSP
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-01-24 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 23:23 [gentoo-dev] [RFC] Initial proof-of-concept for explicit x86 multilib flags Michał Górny
2013-01-23 23:23 ` [gentoo-dev] [PATCH 1/2] Add multilib flags for x86 Michał Górny
2013-01-23 23:23 ` [gentoo-dev] [PATCH 2/2] Use new multilib flags in autotools-multilib Michał Górny
2013-01-24 0:40 ` Alexis Ballier
2013-01-26 12:11 ` Michał Górny
2013-01-26 14:51 ` Alexis Ballier
2013-01-26 15:06 ` Michał Górny
2013-01-26 15:29 ` Alexis Ballier
2013-01-26 14:54 ` Alexis Ballier
2013-01-26 15:08 ` Michał Górny
2013-01-26 15:30 ` Alexis Ballier
2013-01-26 17:06 ` Michał Górny
2013-01-26 17:43 ` Alexis Ballier
2013-01-26 18:12 ` Michał Górny
2013-01-24 17:25 ` [gentoo-dev] " Mike Doty
2013-01-24 21:15 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124221533.64f5d8a9@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=amd64@gentoo.org \
--cc=devrel@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kingtaco@gentoo.org \
--cc=x11@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox