From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: gentoo-x86/eclass: udev.eclass
Date: Tue, 30 Oct 2012 22:16:57 +0100 [thread overview]
Message-ID: <20121030211657.GE809@gentoo.org> (raw)
In-Reply-To: <CAFWqQMQOOhNkv6p-Lt8zWrxYw0U4q=J=x1b1wRGL7Y-gP2xO5g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On 30-10-2012 15:47:51 -0500, Doug Goldstein wrote:
> On Tue, Oct 30, 2012 at 2:17 PM, Fabian Groffen <grobian@gentoo.org> wrote:
> > On 30-10-2012 19:08:39 +0000, Samuli Suominen wrote:
> >> Added: udev.eclass
> >> Log:
> >> New eclass to determine udevdir from udev.pc pkg-config file as requested by many people, without ML review due to unproductive feedback
> >
> > Uhm...
> > Please, stop doing this!
>
> Stop the bike shedding. Provide real constructive improvements. I'm
> not copying and pasting the same hunk of code in a bunch of ebuilds.
We just have policies. It is a bad habit to believe one is not affected
by them.
Samuli just introduced an eclass for which he had to make at least two
commits now right after its introduction to fix issues, and still it has
incorrect code, that should be fixed. (So far he just ignored the issue.)
I wouldn't classify the feedback he got as "unproductive" at all.
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2012-10-30 21:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121030190839.A9A3D21600@flycatcher.gentoo.org>
2012-10-30 19:17 ` [gentoo-dev] Re: gentoo-x86/eclass: udev.eclass Fabian Groffen
2012-10-30 19:31 ` Samuli Suominen
2012-10-30 19:49 ` Samuli Suominen
2012-10-30 20:47 ` Doug Goldstein
2012-10-30 21:16 ` Fabian Groffen [this message]
2012-10-30 21:22 ` Samuli Suominen
2012-10-31 7:50 ` Fabian Groffen
2012-10-31 7:51 ` Samuli Suominen
2012-10-31 8:56 ` Fabian Groffen
2012-10-31 16:08 ` Samuli Suominen
2012-10-31 16:21 ` Gilles Dartiguelongue
2012-10-31 16:55 ` Samuli Suominen
2012-10-31 15:04 ` Alexis Ballier
2012-10-31 16:19 ` Samuli Suominen
2012-10-30 22:04 ` Ciaran McCreesh
2012-10-30 21:24 ` Michał Górny
2012-10-30 21:28 ` Samuli Suominen
2012-10-31 0:39 ` Ryan Hill
2012-10-31 15:26 ` [gentoo-dev] On the usefulness of eclass changelog Alexis Ballier
2012-10-31 15:35 ` Ian Stakenvicius
2012-10-31 15:39 ` Alexis Ballier
2012-10-31 16:15 ` Samuli Suominen
2012-10-31 16:26 ` Ian Stakenvicius
2012-10-31 16:38 ` Alexis Ballier
2012-10-31 16:45 ` Jeroen Roovers
2012-10-31 18:17 ` Rich Freeman
2012-10-31 18:33 ` Samuli Suominen
2012-10-30 19:56 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: udev.eclass Alexis Ballier
2012-10-30 19:57 ` Samuli Suominen
2012-10-30 20:08 ` Alexis Ballier
2012-10-30 20:18 ` Michał Górny
2012-10-30 20:19 ` Samuli Suominen
2012-10-31 14:57 ` Alexis Ballier
2012-10-31 15:09 ` Michał Górny
2012-10-31 15:36 ` Samuli Suominen
2012-10-31 19:17 ` Markos Chandras
2012-10-30 20:06 ` Fabian Groffen
2012-10-30 20:06 ` Ian Stakenvicius
2012-10-30 20:08 ` Samuli Suominen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030211657.GE809@gentoo.org \
--to=grobian@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox