From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B743C138010 for ; Mon, 17 Sep 2012 02:42:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AE16DE06F3; Mon, 17 Sep 2012 02:41:58 +0000 (UTC) Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 16B66E06C8 for ; Mon, 17 Sep 2012 02:41:04 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so9259306pbb.40 for ; Sun, 16 Sep 2012 19:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=u3G5SmZJq1/yieH8wERLMouidQCAVywUkKDoRTfz92Y=; b=g+sbU1VQ6FdNZhLvHB3Cwg1AXThnXihZEPD3sr1xVETLK8cNgBdwCI3h6Ezts+rsZ9 rQWXv4DOGBStx7cBSg//bNt3X7uiNWVHc7mHepFwdx0/myEqBUbION2bvPRwdmCFgr15 +075NJCh64Vw+xWOV2mvl+FuMEx9BNciFY87bQr1e2cg6DMvkGtqPaUUUgJvdpYTpuuf FNp2EUk62MEqZvyQkGxQeEn/WoIAwNT41JlJwTCQnfkl79UR+RL68PGebrizO52On1Bj zkjBOTwzG2uPNHRBwTrIhi+AVbcIIOpc1hoxvpaHKshLWClbJ+m3HAwKeBTablWKy4Ei oAow== Received: by 10.66.75.229 with SMTP id f5mr17334274paw.47.1347849664232; Sun, 16 Sep 2012 19:41:04 -0700 (PDT) Received: from smtp.gmail.com:587 (74-95-192-101-SFBA.hfc.comcastbusiness.net. [74.95.192.101]) by mx.google.com with ESMTPS id wn4sm6141199pbc.55.2012.09.16.19.41.01 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Sep 2012 19:41:03 -0700 (PDT) Received: by smtp.gmail.com:587 (sSMTP sendmail emulation); Sun, 16 Sep 2012 19:41:14 -0700 Date: Sun, 16 Sep 2012 19:41:14 -0700 From: Brian Harring To: Mike Frysinger Cc: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [PATCH] eutils: Warn on built_with_use usage Message-ID: <20120917024114.GE23030@localhost> References: <1347781864-29497-1-git-send-email-ferringb@gmail.com> <201209162210.48503.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201209162210.48503.vapier@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: 3ebcb549-60ba-4924-821b-39bed9011ec5 X-Archives-Hash: 3a44aace02bcaca2ead9fb4b03e4190d On Sun, Sep 16, 2012 at 10:10:47PM -0400, Mike Frysinger wrote: > On Sunday 16 September 2012 03:51:04 Brian Harring wrote: > > + if ! has $EAPI 0 1 2 3; then > > + eqawarn "built_with_use should not be used in $EAPI; use USE deps." > > + elif has $EAPI 2 3; then > > + if [[ $hidden == yes ]] || $missing_was_set; then > > + eqawarn "built_with_use in EAPI=$EAPI without --missing or -- > hidden > > usage, should use USE deps instead." + else > > + eqawarn "built_with_use should not be used; upgrade to EAPI=4 > instead" > > + fi > > + fi > > i'd do: > case ${EAPI:-0} in > # No support in these EAPIs, so don't warn. > 0|1) ;; > # Maybe warn as some functionality exist. > 2|3) [[...]] && eqawarn "..." ;; > # Assume EAPI=4 or newer where all functionality exists. > *) eqawarn "..." ;; > esac I'd be fine w/ it; worth noting, that was a 4am patch, so I'm not claiming perfect implementatoin there. :) My main focus here is switching built_with_use to actively nagging people to stop using it; this includes nagging EAPI0/1 users of it. Sans the implementation details, anyone got complaints with the intent? ~brian