From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 68123138010 for ; Wed, 5 Sep 2012 11:26:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2527CE07E0; Wed, 5 Sep 2012 11:25:37 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 2FDF5E07AA for ; Wed, 5 Sep 2012 11:24:13 +0000 (UTC) Received: from pomiocik.lan (213-238-104-238.adsl.inetia.pl [213.238.104.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 7705C33D791; Wed, 5 Sep 2012 11:24:11 +0000 (UTC) Date: Wed, 5 Sep 2012 13:25:13 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: ciaran.mccreesh@googlemail.com Subject: Re: [gentoo-dev] [Future EAPI] src_fetch() phase function to support VCS fetching Message-ID: <20120905132513.74273b28@pomiocik.lan> In-Reply-To: <20120905120722.04921249@googlemail.com> References: <20120904184345.77696965@pomiocik.lan> <20120905082554.4bfb7452@googlemail.com> <20120905103811.6e9e2e79@pomiocik.lan> <3287936.v4OyhU68xF@grenadine> <20120905114903.3b2efe78@googlemail.com> <20120905130005.61efb834@pomiocik.lan> <20120905120722.04921249@googlemail.com> Organization: Gentoo X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.11; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/RNvrtU4.N55_LfWX54Q40JM"; protocol="application/pgp-signature" X-Archives-Salt: 8be4b437-fe2f-4fcb-b5e0-390e39125e3a X-Archives-Hash: a8b038dc8454c63f4dc62d75d688e395 --Sig_/RNvrtU4.N55_LfWX54Q40JM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 5 Sep 2012 12:07:22 +0100 Ciaran McCreesh wrote: > On Wed, 5 Sep 2012 13:00:05 +0200 > Micha=C5=82 G=C3=B3rny wrote: > > > I guess that's a pretty comprehensive "we need to do this > > > properly" then. > >=20 > > Did I say we don't need to? We have the two eclasses which need to > > do this properly, right? So what's your problem? >=20 > The problem is that we need to work out how to deal with this at least > for Subversion, and probably for CVS too... As much as we'd like to, > we can't just roll out a src_fetch without eclass changes. This > doesn't appear to be a trivial feature to provide. First of all, subversion isn't a problem here. Subversion doesn't have native branches. It's just directories in the tree, with tree having linear history. In other words, it just works. So it remains CVS and possibly darcs. But considering that the issue is so unlikely and so small, we can as well assume that the affected ebuilds should set ECVS_LOCALNAME to something with the branch. This is in line with how we handle SRC_URI collisions. And in any case, we may just decide to use a ECVS_LOCALNAME with branch appended by default. Finally, I don't think eclasses are really forced to use src_fetch() from day one. src_unpack() will still work for them, and we can adjust them gradually. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/RNvrtU4.N55_LfWX54Q40JM Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iJwEAQEIAAYFAlBHNpoACgkQfXuS5UK5QB18wQQArPkIxT8YN8MCfBS5w66vLg3p ARdGfxsgmIl+ItT19FZ/wObBHfPYoWYXURd+Wlp6UaM0iKaaeCQ/0AMjmpy+GlwR jdjuZKowQqKsm6r871ukH1xJoSKumqOzsnRSPN1/FOsBJxooTJqWcijS4pPLHnPw PCpscUfRI5aL5xN45R4= =q4ph -----END PGP SIGNATURE----- --Sig_/RNvrtU4.N55_LfWX54Q40JM--