From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9F09A138010 for ; Sat, 18 Aug 2012 15:46:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0F1AA21C00B; Sat, 18 Aug 2012 15:46:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 4DBDAE076B for ; Sat, 18 Aug 2012 15:45:14 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 85CE21B4022 for ; Sat, 18 Aug 2012 15:45:13 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto. Date: Sat, 18 Aug 2012 11:45:12 -0400 User-Agent: KMail/1.13.7 (Linux/3.5.0; KDE/4.6.5; x86_64; ; ) References: <1345148385-27699-1-git-send-email-mgorny@gentoo.org> <201208172325.11229.vapier@gentoo.org> <20120818092120.0862a99e@pomiocik.lan> In-Reply-To: <20120818092120.0862a99e@pomiocik.lan> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3046537.6EdE4gVexm"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201208181145.13447.vapier@gentoo.org> X-Archives-Salt: f7274d26-8f69-4960-9d6f-9f4900906cf6 X-Archives-Hash: 7d6e19edcd353dc7af0b1490946faab2 --nextPart3046537.6EdE4gVexm Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 18 August 2012 03:21:20 Micha=C5=82 G=C3=B3rny wrote: > On Fri, 17 Aug 2012 23:25:10 -0400 Mike Frysinger wrote: > > On Thursday 16 August 2012 16:19:44 Micha=C5=82 G=C3=B3rny wrote: > > > --- a/eutils.eclass > > > +++ b/eutils.eclass > > >=20 > > > +# Install all specified s into . This doesn't > > > modify global +# 'insinto' path. Alike doins, calls 'die' on > > > failure in EAPI 4+; in earlier +# EAPIs, returns false in that case. > >=20 > > i don't really see the point in differentiating here. we have plenty > > of helpers that have always implicitly called die regardless of the > > EAPI level, and it's not like you'd be breaking any existing behavior > > since no one is using this already. and even then, you'd be > > "breaking" builds that were already broken. >=20 > Maybe. Alternatively, I could end up doing doins || die || die. It will > work but what's the point? the double die only kicks in with EAPI=3D4+, and even then is hidden to mos= t=20 people at the code level. it also looks a lot better than: ( insinto ... && doins ... ) case ${EAPI:-0} in 0|1|2|3) [[ $? -ne 0 ]] && die ;; esac vs (insinto ... && doins ...) || die =2Dmike --nextPart3046537.6EdE4gVexm Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQL7iJAAoJEEFjO5/oN/WBa5UQAKqxvjf+ssCgkztsUuUNiwbu KDuWPjfLntVyqys6//UNjtpeL7O/ppAppiAVHNFfN0mu/Oz9cPrVpAOitcYiQdJ8 mGn6W1DaClOxf+N6Kfmil+TKUIvsL0EuOt2DZvLkhDm5wr0O9/PSykW70WJG79U1 OZXvS2gpf2vTyHTs9Y2aAe+k1MNR8qRgy1lFtShRZNw43gjZd9qS4bnBM+0YJqlr ZghkvfQa6hTVsiogF11U85sm6T/VS4P3qcP8MM76PWobFc7g8X2AWXQ/Dlo2DHTM Sld4y2FOeKGTCzAnKC+0WCVlubARLptozTf16SdlYdepPzsDkIDL832evUO/zCDn 3EHfKdbQX/6bNGlFOZKNsn7wt6L27RnHcCUAZwkcFnN1Do4faxWUdZOQbbjQov5R R1G5vQO/UFZPCCO+YX4itMoT8+di9thFbWHAicgeuxgKPpWthawvylbL1CGle79g YIq3oDYoUqcbCbV4ovaENK1aMpHGiUk8047rjOPuiX9AXQehok/5KR0aF1+6Jf+m DWuBV/fzeAyLXzuGjA44Sp5oJlo8Z8JJV0uErWx+3w3Smq0botoxznMpCVqixIIe J+2JNxYj+Af4ZSS2Zm3SUalICO1c9IHHTZkVj0ErDT6Gi8XcpPSic0naw0sP+LFi WFKb0D4p67H4Xz9yaQjw =Yfph -----END PGP SIGNATURE----- --nextPart3046537.6EdE4gVexm--