From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ulm@gentoo.org
Subject: Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto.
Date: Thu, 16 Aug 2012 22:46:40 +0200 [thread overview]
Message-ID: <20120816224640.482bd430@pomiocik.lan> (raw)
In-Reply-To: <20525.23006.307734.925683@a1i15.kph.uni-mainz.de>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Thu, 16 Aug 2012 22:36:46 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:
> >>>>> On Thu, 16 Aug 2012, Michał Górny wrote:
>
> > +dointo() {
> > + [[ ${#} -gt 2 ]] || die 'Synopsis: dointo <directory>
> > <file> [...]' +
> > + local directory=${1}
> > + shift
> > +
> > + (
> > + insinto "${directory}"
>
> Shouldn't there be checking for errors here, for the case that insinto
> fails?
Hmm, I don't even know if insinto should ever fail. And if it does,
then the following doins should fail as well, I guess.
But I see no problem adding '&& \' there if necessary.
> > + doins "${@}"
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
next prev parent reply other threads:[~2012-08-16 20:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 20:19 [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto Michał Górny
2012-08-16 20:19 ` [gentoo-dev] [PATCH eutils 2/2] Convert simple uses to dointo/newinto Michał Górny
2012-08-16 20:29 ` [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto Diego Elio Pettenò
2012-08-16 20:45 ` Michał Górny
2012-08-16 20:45 ` Diego Elio Pettenò
2012-08-16 21:23 ` Michał Górny
2012-08-16 20:36 ` Ulrich Mueller
2012-08-16 20:46 ` Michał Górny [this message]
2012-08-16 22:02 ` Ulrich Mueller
2012-08-16 22:23 ` [gentoo-dev] [PATCH eutils] " Michał Górny
2012-08-17 16:53 ` [gentoo-dev] [PATCH eutils 1/2] " Jeroen Roovers
2012-08-17 17:13 ` Michał Górny
2012-08-18 3:25 ` Mike Frysinger
2012-08-18 7:21 ` Michał Górny
2012-08-18 15:45 ` Mike Frysinger
2012-09-19 5:45 ` Mike Frysinger
2012-09-19 7:51 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816224640.482bd430@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox