From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-53791-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id C817E13800E
	for <garchives@archives.gentoo.org>; Sat,  4 Aug 2012 20:50:41 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id DA639E0660;
	Sat,  4 Aug 2012 20:50:25 +0000 (UTC)
Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181])
	by pigeon.gentoo.org (Postfix) with ESMTP id CC208E0466
	for <gentoo-dev@lists.gentoo.org>; Sat,  4 Aug 2012 20:49:41 +0000 (UTC)
Received: by obbup19 with SMTP id up19so3508500obb.40
        for <gentoo-dev@lists.gentoo.org>; Sat, 04 Aug 2012 13:49:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:date:from:to:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        bh=b+Yo/myTmBQw7X3aq5RncXrR5WNlTOhkQZXTWozEAeo=;
        b=rWU7/ofzrRdCBmLB6SklwFU6remum6FdS2fGs5Ejezw+zp1vFr9OQJHIGlYe8/X031
         ZA2oTMW86qWiG9Rn1FYRrz/gUbBgdHVW3w+yrOK4K1EQUqQHjWU5QwOlR/N2mTWaIAVL
         gpQxRvknQLlmiZvFbcOKJsMJ1BTd2tj6S3q2AuqpbOxM/QcGuOaitrR7hczCjbBLfB7X
         F5mk3I0RdOpOlhhITdeSLVuLB9+82hnwEE2ar+7a4SX8ruvh6SNooEvXbMUIWIdFcDvL
         CMB7fqB1lLYxDXvQAMpkO+NUT9StMJgm1GTb9mrS9GFZYwfetX9TKOjzwHM33A0mKA9y
         EAMQ==
Received: by 10.60.2.105 with SMTP id 9mr11884635oet.65.1344113381112;
        Sat, 04 Aug 2012 13:49:41 -0700 (PDT)
Received: from linux1 (cpe-76-187-95-170.tx.res.rr.com. [76.187.95.170])
        by mx.google.com with ESMTPS id pj4sm13293093obb.20.2012.08.04.13.49.39
        (version=SSLv3 cipher=OTHER);
        Sat, 04 Aug 2012 13:49:40 -0700 (PDT)
Sender: William Hubbs <w.d.hubbs@gmail.com>
Received: by linux1 (sSMTP sendmail emulation); Sat, 04 Aug 2012 15:49:38 -0500
Date: Sat, 4 Aug 2012 15:49:38 -0500
From: William Hubbs <williamh@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in
 sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog
Message-ID: <20120804204938.GA31156@linux1>
Mail-Followup-To: gentoo-dev@lists.gentoo.org
References: <20120803212917.18C2E2004B@flycatcher.gentoo.org>
 <501CCFB9.8010500@gentoo.org>
 <CAFWqQMSWgg1-YmmLrVB3YFeM+zKWi8X9Q9Gv06swMRDNT+mQ4w@mail.gmail.com>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l"
Content-Disposition: inline
In-Reply-To: <CAFWqQMSWgg1-YmmLrVB3YFeM+zKWi8X9Q9Gv06swMRDNT+mQ4w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Archives-Salt: 5de9de21-2274-4cb8-966d-5961b78d1622
X-Archives-Hash: 927920ae0818743b9151312ecc936b6b


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 04, 2012 at 02:22:52PM -0500, Doug Goldstein wrote:
> On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@gentoo.org> wr=
ote:
> > If you don't use double [[ then ${ROOT} will need "" quoting
> >
>=20
> Don't do top post code reviews. Snip out the context and do code
> reviews inline so that your feedback is meaningful. Top posting and
> leaving the entire commit with CVS metadata and all is just wasteful
> and silly.

This has been fixed.

WRT Doug's request, the important part is "snip out the context". Don't
just insert comments and leave the entire commit in the message.

Thanks,

William


--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlAdiuIACgkQblQW9DDEZTgQGgCgmqavO8XO/am67undWsElk331
veEAnjNNpHCK9KTe/lXoVuRSEUf8W/r7
=odaZ
-----END PGP SIGNATURE-----

--XsQoSWH+UP9D9v3l--