From: William Hubbs <williamh@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog
Date: Sat, 4 Aug 2012 15:49:38 -0500 [thread overview]
Message-ID: <20120804204938.GA31156@linux1> (raw)
In-Reply-To: <CAFWqQMSWgg1-YmmLrVB3YFeM+zKWi8X9Q9Gv06swMRDNT+mQ4w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On Sat, Aug 04, 2012 at 02:22:52PM -0500, Doug Goldstein wrote:
> On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> > If you don't use double [[ then ${ROOT} will need "" quoting
> >
>
> Don't do top post code reviews. Snip out the context and do code
> reviews inline so that your feedback is meaningful. Top posting and
> leaving the entire commit with CVS metadata and all is just wasteful
> and silly.
This has been fixed.
WRT Doug's request, the important part is "snip out the context". Don't
just insert comments and leave the entire commit in the message.
Thanks,
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-08-04 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120803212917.18C2E2004B@flycatcher.gentoo.org>
2012-08-04 7:31 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog Samuli Suominen
2012-08-04 19:22 ` Doug Goldstein
2012-08-04 20:49 ` William Hubbs [this message]
2012-08-05 23:20 ` Marc Schiffbauer
2012-08-05 23:25 ` Peter Stuge
2012-08-06 0:49 ` Marc Schiffbauer
2012-08-05 23:26 ` Diego Elio Pettenò
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120804204938.GA31156@linux1 \
--to=williamh@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox