From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D038313800E for ; Mon, 23 Jul 2012 15:23:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 45017E0768; Mon, 23 Jul 2012 15:23:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 72082E075B for ; Mon, 23 Jul 2012 15:22:42 +0000 (UTC) Received: from sera-17.lan (102-148.78-83.cust.bluewin.ch [83.78.148.102]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sera) by smtp.gentoo.org (Postfix) with ESMTPSA id EA6B21B433A for ; Mon, 23 Jul 2012 15:22:40 +0000 (UTC) Date: Mon, 23 Jul 2012 17:22:24 +0200 From: Ralph Sennhauser To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: l10n.eclass Message-ID: <20120723172224.1a141f96@sera-17.lan> In-Reply-To: References: <20120719151422.1fb9883b@sera-17.lan> <20120720093332.02446725@sera-17.lan> Organization: Gentoo Linux X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/yWPSk9v.Ymw0IN5/qT/py/A"; protocol="application/pgp-signature" X-Archives-Salt: 09f8d606-1e86-4e85-9ca1-62acc99d1a12 X-Archives-Hash: bf97b2cf85c8001c195b222796e95e6b --Sig_/yWPSk9v.Ymw0IN5/qT/py/A Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 23 Jul 2012 20:29:44 +0800 Ben de Groot wrote: > >> # ones. This function is normally used internally in this eclass, > >> not by # l10n.eclass consumers. > >> l10n_get_locales() { =20 > > > > I'd mark this function @INTERNAL then, at least until someone can > > presents a use case. > > If you are sufficiently sure this function shouldn't be used by > > consumers you could remove the function =20 >=20 > There are use cases, e.g. net-im/qtwitter-0.10.0-r1 for which I have > an editted -r10 revision in my dev overlay. I'm sure it could be > handled with l10n_for_each_locale_do, but the migration is more > straight-forward by simply using l10n_get_locales in this case. >=20 > This is why I worded it "normally" instead of "only". Maybe the > wording could be improved? The primary concern should be expressiveness. That said, qttwitter looks like a good example use case. You have convinced me. src_configure() { qmake4 PREFIX=3D"/usr" LANGS=3D"$(l10n_get_locales)" } Maybe l10n_get_enabled_locales would read even more natural here? Either way I'd drop the internal entirely as it also provides a simple way to "sanitize" LINGUAS without relying on the package manager. ie. setting 'LINGUAS=3D"$(l10n_get_locales)"' in an ebuild would enable the possible EAPI 5 behaviour described later in this thread, which would allow direct use of LINGUAS. The only difference being the backup locale. --Sig_/yWPSk9v.Ymw0IN5/qT/py/A Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJQDWw6AAoJEIUJ+svaV163FPwH/iO1aVwaFKD/HSWxHuEMhgCv +PcPLtFG6JfN3G/RF5FQUtmsZOATcWQzdYZOsIcu64hzOMib8bVuTbmaGoBwd6gu szhiNepbeMHe9G1zWSfOLN1UB7p2ubZwclildvxWIJCLlMICZ0121cSL0dpDc027 kXP6EGIQ3peWa66y0momyLblNj328rTM8ifG5h0yfoizbpWtS+OJSuQNZiNwI83i Z6tBNzCwNBN6iGZ1C1x4pQxeckL4NPB4TbghwQBBi5H1+hA5RExYTpkOMuU0/JCn MR7ElED+krBEAbTN1TNvkAAPmYpBu9a058iFPijSvidM6GtfS+0jIv9NwuZMHFA= =Z+K9 -----END PGP SIGNATURE----- --Sig_/yWPSk9v.Ymw0IN5/qT/py/A--