From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.77) (envelope-from ) id 1SqP60-0004rL-DX for garchives@archives.gentoo.org; Sun, 15 Jul 2012 13:42:48 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D068921C012; Sun, 15 Jul 2012 13:42:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 6D2E9E0603 for ; Sun, 15 Jul 2012 13:42:05 +0000 (UTC) Received: from pomiocik.lan (87-205-69-186.adsl.inetia.pl [87.205.69.186]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id D2C161B4006; Sun, 15 Jul 2012 13:42:03 +0000 (UTC) Date: Sun, 15 Jul 2012 15:42:02 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: pesa@gentoo.org Subject: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass Message-ID: <20120715154202.09edb560@pomiocik.lan> In-Reply-To: References: <20120713083456.61c78c04@gentoo.org> <20120713095057.186f3dc3@gentoo.org> <20120714160042.7e8ea9b8@pomiocik.lan> Organization: Gentoo X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/LEhNNS.j9PDZ6NO0Z0QNBJM"; protocol="application/pgp-signature" X-Archives-Salt: 2b92045d-4924-45f7-89a4-61253a58289f X-Archives-Hash: d596c175f687248e29cf8d3071455294 --Sig_/LEhNNS.j9PDZ6NO0Z0QNBJM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 15 Jul 2012 13:00:47 +0200 Davide Pesavento wrote: > On Sat, Jul 14, 2012 at 4:00 PM, Micha=C5=82 G=C3=B3rny > wrote: > > On Sat, 14 Jul 2012 12:29:59 +0200 > > Davide Pesavento wrote: > > > >> On Fri, Jul 13, 2012 at 3:50 PM, Alexis Ballier > >> wrote: > >> > On Fri, 13 Jul 2012 15:26:58 +0200 > >> > Davide Pesavento wrote: > >> > > >> >> > [...] > >> >> >> + # backward compatibility for non-array variables > >> >> >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS > >> >> >> 2>/dev/null > >> >> >> 2>&1)" !=3D "declare -a"* ]]; then > >> >> >> + dodoc ${DOCS} || die "dodoc failed" > >> >> >> + fi > >> >> >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS > >> >> >> 2>/dev/null 2>&1)" !=3D "declare -a"* ]]; then > >> >> >> + dohtml -r ${HTML_DOCS} || die "dohtml failed" > >> >> >> + fi > >> >> >> } > >> >> > > >> >> > maybe issue an eqawarn in that case telling people to convert > >> >> > to arrays; some time later make this an ewarn telling > >> >> > non-array support will be removed and again later make this a > >> >> > die :) (if you take that route i would expect you to start > >> >> > converting packages to use arrays) > >> >> > > >> >> > >> >> We have no intention of deprecating non-array variables in > >> >> qt4-r2 eclass. > >> > > >> > why ? having two codepaths for the same thing, one being > >> > inferior, sounds like a good reason to deprecate the inferior > >> > one :) > >> > > >> > A. > >> > > >> > >> Maintaining these two codepaths has practically zero cost, while > >> forcing every ebuild using qt4-r2 to switch to arrays would waste > >> developers' time which is better spent elsewhere. > >> > >> Furthermore, the non-array variant is not necessarily inferior, > >> because it allows you to use bash globbing, brace expansion, etc... > > > > And arrays stopped to allow that overnight? > > >=20 > I mean that the following won't work as you might expect: >=20 > DOCS=3D("*.txt") I doubt anyone would expect quoted string to be evaluated as glob. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/LEhNNS.j9PDZ6NO0Z0QNBJM Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iJwEAQEIAAYFAlACyLIACgkQfXuS5UK5QB25QAP/VA26uSJS32qup4e/lz4GXPr8 vWTI/zCla6ReQ07hsRlJJg5B5kawCgknQdW0+3oN3dEVgyzrq/8rCTFeCZBQR3uP Z/weUR8jDMY7+ZnMF1HB6ixO7N9cg8wwUxNj88JujIXN6envti4ZxsF2Guq5YG69 b3sqDapBC6uioX3l4eY= =kLfo -----END PGP SIGNATURE----- --Sig_/LEhNNS.j9PDZ6NO0Z0QNBJM--