From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.77) (envelope-from ) id 1Sq2uk-00012k-Vl for garchives@archives.gentoo.org; Sat, 14 Jul 2012 14:01:43 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 25719E07AB; Sat, 14 Jul 2012 14:01:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id F2390E06B1 for ; Sat, 14 Jul 2012 14:00:37 +0000 (UTC) Received: from pomiocik.lan (static-81-219-106-87.devs.futuro.pl [81.219.106.87]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 3A1A91B408F; Sat, 14 Jul 2012 14:00:36 +0000 (UTC) Date: Sat, 14 Jul 2012 16:00:42 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: pesa@gentoo.org Subject: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass Message-ID: <20120714160042.7e8ea9b8@pomiocik.lan> In-Reply-To: References: <20120713083456.61c78c04@gentoo.org> <20120713095057.186f3dc3@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/yQ=9BW0hNer1C8FbY8TKSN2"; protocol="application/pgp-signature" X-Archives-Salt: d1ffc4fa-8509-4392-a5b3-8a7f9f88c09a X-Archives-Hash: cc74b95adb245c4e19ff7c167721b7a5 --Sig_/yQ=9BW0hNer1C8FbY8TKSN2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 14 Jul 2012 12:29:59 +0200 Davide Pesavento wrote: > On Fri, Jul 13, 2012 at 3:50 PM, Alexis Ballier > wrote: > > On Fri, 13 Jul 2012 15:26:58 +0200 > > Davide Pesavento wrote: > > > >> > [...] > >> >> + # backward compatibility for non-array variables > >> >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS 2>/dev/null > >> >> 2>&1)" !=3D "declare -a"* ]]; then > >> >> + dodoc ${DOCS} || die "dodoc failed" > >> >> + fi > >> >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS > >> >> 2>/dev/null 2>&1)" !=3D "declare -a"* ]]; then > >> >> + dohtml -r ${HTML_DOCS} || die "dohtml failed" > >> >> + fi > >> >> } > >> > > >> > maybe issue an eqawarn in that case telling people to convert to > >> > arrays; some time later make this an ewarn telling non-array > >> > support will be removed and again later make this a die :) > >> > (if you take that route i would expect you to start converting > >> > packages to use arrays) > >> > > >> > >> We have no intention of deprecating non-array variables in qt4-r2 > >> eclass. > > > > why ? having two codepaths for the same thing, one being inferior, > > sounds like a good reason to deprecate the inferior one :) > > > > A. > > >=20 > Maintaining these two codepaths has practically zero cost, while > forcing every ebuild using qt4-r2 to switch to arrays would waste > developers' time which is better spent elsewhere. >=20 > Furthermore, the non-array variant is not necessarily inferior, > because it allows you to use bash globbing, brace expansion, etc... And arrays stopped to allow that overnight? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/yQ=9BW0hNer1C8FbY8TKSN2 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iJwEAQEIAAYFAlABe5AACgkQfXuS5UK5QB3DtgP/UB5lt60d4B2NMmBUmPji1uTy QbgkwevwMKqsO1sSH7dZrcZsPyPSxTJF9CnozpUT+G/KxXDSun9RibnwMvPnFdLW Fh81m8oKhzV3Rn1vqrfTeQh+ZiGrLYKIZTPLs8RqnsJTYDcYB2oefMwWobI6M4qi y/FP0UZyjCDYAwHhwlg= =BNMs -----END PGP SIGNATURE----- --Sig_/yQ=9BW0hNer1C8FbY8TKSN2--