From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SbZYA-0001OS-T5 for garchives@archives.gentoo.org; Mon, 04 Jun 2012 15:50:37 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 77111E068F; Mon, 4 Jun 2012 15:50:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 4C442E064A for ; Mon, 4 Jun 2012 15:49:39 +0000 (UTC) Received: from pomiocik.lan (p14.ppp.polbox.pl [213.241.7.14]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id D23DA1B400C; Mon, 4 Jun 2012 15:49:36 +0000 (UTC) Date: Mon, 4 Jun 2012 17:50:47 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: hasufell@gentoo.org Subject: Re: [gentoo-dev] [PATCH vcs-snapshot] Use ${WORKDIR}/${P} rather than ${S} to support ${S} overrides. Message-ID: <20120604175047.1d1ed5a4@pomiocik.lan> In-Reply-To: <4FCCC412.6000000@gentoo.org> References: <1338803954-3814-1-git-send-email-mgorny@gentoo.org> <4FCCC412.6000000@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/chVVJ7bq4eD7BV/SHAuGqhL"; protocol="application/pgp-signature" X-Archives-Salt: 3f8508a2-e36d-40fa-a611-a53c7c39ba94 X-Archives-Hash: bea4e11f42ccd592fa3a5fa3f0015c11 --Sig_/chVVJ7bq4eD7BV/SHAuGqhL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 04 Jun 2012 16:20:02 +0200 hasufell wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On 06/04/2012 11:59 AM, Micha=C5=82 G=C3=B3rny wrote: > > One could set S to work on a subtree of the tarball rather than the > > whole tarball. Considering that, it's probably better to use=20 > > ${WORKDIR}/${P} rather than ${S}. > >=20 > > Fixes: https://bugs.gentoo.org/show_bug.cgi?id=3D419479 ---=20 > > gx86/eclass/vcs-snapshot.eclass | 5 +++-- 1 file changed, 3 > > insertions(+), 2 deletions(-) > >=20 > > diff --git a/gx86/eclass/vcs-snapshot.eclass > > b/gx86/eclass/vcs-snapshot.eclass index 6748360..23cd696 100644 --- > > a/gx86/eclass/vcs-snapshot.eclass +++ > > b/gx86/eclass/vcs-snapshot.eclass @@ -9,7 +9,8 @@ # @DESCRIPTION: # > > This eclass provides a convenience src_unpack() which does support=20 > > # working with snapshots generated by various VCS-es. It unpacks > > those -# to ${S} rather than the original directory containing > > commit id. +# to ${WORKDIR}/${P} rather than the original directory > > containing +# commit id. # # Note that this eclass handles only > > unpacking. You need to specify # SRC_URI yourself, and call any > > autoreconfiguration as necessary. @@ -41,5 +42,5 @@ > > vcs-snapshot_src_unpack() { > >=20 > > # github, bitbucket: username-projectname-hash # gitweb: > > projectname-tagname-hash - mv *-*-[0-9a-f]*[0-9a-f]/ "${S}" > > || die=20 > > + mv *-*-[0-9a-f]*[0-9a-f]/ "${WORKDIR}"/${P} || die } >=20 > Currently that eclass does not support multiple snapshot > sources/tarballs. Use case? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/chVVJ7bq4eD7BV/SHAuGqhL Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iJwEAQEIAAYFAk/M2VsACgkQfXuS5UK5QB2U4AP9HVg+B5hyfzRpZ6BQu4U1NYMU WXhKFrnu8ZWwG2tDMsBLPTHjSZdy6aVw/ANiMhNt3+fuyY6QTC9T9ynBKZQSKlmt 0MxgetDSnk3KoEGwOH3fSVrjPG2oeirdVaX2donfI0BU4wiLIfnEflTZcqRmw3ln 1yTjD55pqZJZ7oHGm8c= =Zo3i -----END PGP SIGNATURE----- --Sig_/chVVJ7bq4eD7BV/SHAuGqhL--