From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Saafp-00081k-7w for garchives@archives.gentoo.org; Fri, 01 Jun 2012 22:50:25 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CE566E059C; Fri, 1 Jun 2012 22:50:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id F2324E0574 for ; Fri, 1 Jun 2012 22:49:37 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 692D21B4012 for ; Fri, 1 Jun 2012 22:49:37 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass Date: Fri, 1 Jun 2012 18:49:38 -0400 User-Agent: KMail/1.13.7 (Linux/3.4.0; KDE/4.6.5; x86_64; ; ) References: <4FB97D1D.9070004@gentoo.org> <4FBD892A.8030807@gentoo.org> In-Reply-To: <4FBD892A.8030807@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7249190.J4gdcYJt8A"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201206011849.39133.vapier@gentoo.org> X-Archives-Salt: 09845d0a-e678-4f66-80ba-2d8624ed7790 X-Archives-Hash: 005d1aba2b5ece00f6012c1b88e536ee --nextPart7249190.J4gdcYJt8A Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 23 May 2012 21:04:42 hasufell wrote: > # @FUNCTION: _iconins > # @DESCRIPTION: > # function for use in doicon and newicon mark it @INTERNAL > if [[ -z $size ]] ; then ${size} > if [[ $function =3D=3D doicon ]] ; then ${function} > if [[ $function =3D=3D newicon ]] ; then ${function} > doicon() { > local function=3D$FUNCNAME > _iconins "$@" passing the funcname in this way is kind of ugly. you could do: _iconins ${FUNCNAME} "$@" and then at the top of _iconins: local funcname=3D$1; shift i guess if we all agree this complication is useful, then fix the nits and= =20 let's merge it =2Dmike --nextPart7249190.J4gdcYJt8A Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPyUcDAAoJEEFjO5/oN/WBJCUQALH86Fr0iwJ0azvWTYwBHXzJ CXDP/10IRIM/SMimvyNNa22AOdiUhxhQuex+KJJYXovOODtpTZTcMIFw5RKOVRu6 HehfArSswBPgRvTxHk7NAiDtILCiNm05f60IkfYLk/XdKGQl1+T7D39WpxScml7A LQ/ykyRRnxWrZ97iDW7ULjjFAe+t+g9HSGwbbmwtBelcdlYhUPJ7On98Vaz7dSpE 6AdXsWKfLL896aSwFB5+DsRUf7MxlD4MSeUlc1s2Qa7VkkmunjGmCCUCiF8VOMkH eKOMYT1tljAbsMv2DULcZ+OVDu/S0aORxDSdhutUW4qnV9KFu2VYv/2b3CrVUrY7 TaAATkY8nP8pgzmTPlJj4bLzXfKvhD43sRNsILW0qWWSoGI/1LNP0lUrCpWWx7bi u8GT/AQ7dUF5AMCmbOHQOpBk1ABIkmjJH/gycCAHaZTUfRnBfCFcYqNy8EImx+r+ oIU7KcYlt7kBDCj9aFWjXOrbh7m7Imw9rxS+8/Io0z6cC5+g3w953nS1pmSndHUn TKXaIcERjO2Rm2RKdkuKrxHtz1Ppkn8zunrv3yRUhV7Uie0g7ll8PXblIJAOr1P6 FH6lXVMRRtyyz4gw0xGBy9ENEG9drhMi5Y5f3rySHekmfEdBNCeFvMc37SQ4KGe+ kiAKJcjFv/Pnhx80wp1L =eyAH -----END PGP SIGNATURE----- --nextPart7249190.J4gdcYJt8A--