public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] games.eclass: allow EAPI=4
@ 2012-05-29 19:00 Sergei Trofimovich
  2012-05-29 19:36 ` hasufell
  2012-06-02  1:47 ` [gentoo-dev] " Mike Frysinger
  0 siblings, 2 replies; 4+ messages in thread
From: Sergei Trofimovich @ 2012-05-29 19:00 UTC (permalink / raw
  To: gentoo-dev; +Cc: games


[-- Attachment #1.1: Type: text/plain, Size: 107 bytes --]

Nice to drop '|| die' and have REQUIRED_USE in games ebuilds

OK to push?

Thanks!

-- 

  Sergei

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: games.eclass.patch --]
[-- Type: text/x-patch, Size: 658 bytes --]

Index: games.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/games.eclass,v
retrieving revision 1.147
diff -u -u -r1.147 games.eclass
--- games.eclass	27 Dec 2011 17:55:12 -0000	1.147
+++ games.eclass	29 May 2012 18:53:22 -0000
@@ -15,7 +15,7 @@
 
 case ${EAPI:-0} in
 	0|1) EXPORT_FUNCTIONS pkg_setup src_compile pkg_preinst pkg_postinst ;;
-	2|3) EXPORT_FUNCTIONS pkg_setup src_configure src_compile pkg_preinst pkg_postinst ;;
+	2|3|4) EXPORT_FUNCTIONS pkg_setup src_configure src_compile pkg_preinst pkg_postinst ;;
 	*) die "no support for EAPI=${EAPI} yet" ;;
 esac
 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] [PATCH] games.eclass: allow EAPI=4
  2012-05-29 19:00 [gentoo-dev] [PATCH] games.eclass: allow EAPI=4 Sergei Trofimovich
@ 2012-05-29 19:36 ` hasufell
  2012-05-29 20:00   ` Mike Gilbert
  2012-06-02  1:47 ` [gentoo-dev] " Mike Frysinger
  1 sibling, 1 reply; 4+ messages in thread
From: hasufell @ 2012-05-29 19:36 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/29/2012 09:00 PM, Sergei Trofimovich wrote:
> Nice to drop '|| die' and have REQUIRED_USE in games ebuilds
> 
> OK to push?
> 
> Thanks!
> 

+1 for bumping

but is this known to not break anything?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPxSUhAAoJEFpvPKfnPDWzGqEH/0gcLXA11HtHwYTKwVI7eEak
9BucZAJm+M98+UW6DJQq9UeU+Yu4W478K+d8ntI09VHqnJ6/Khy3xGeXMU1Sq6Lh
whtg8kGvxgjxhDRbkUTUdCQAdG1l5aTr3ZiHP5pp9ykwmgiAXEctHy11SeKtjpNd
dP94BLxrDTMZRFC5N8H4+OhgT0lUdLv1yFUYRNn9kJNVXPVo+YD6XF1urOe39TQi
lkX5dUT+mXTp66g3bt1VE9aq5XfFYFaqoCzZSo9+T1K0LhO7wyxfEUxwLa3t+vbR
mmm7U9A+kODE1Lc0lBRf4jV5yqkrRMcSFcwdcJnUxVmsRN0mkz2WjcnYsUf9Vfs=
=HfDy
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] [PATCH] games.eclass: allow EAPI=4
  2012-05-29 19:36 ` hasufell
@ 2012-05-29 20:00   ` Mike Gilbert
  0 siblings, 0 replies; 4+ messages in thread
From: Mike Gilbert @ 2012-05-29 20:00 UTC (permalink / raw
  To: gentoo-dev

On Tue, May 29, 2012 at 3:36 PM, hasufell <hasufell@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/29/2012 09:00 PM, Sergei Trofimovich wrote:
>> Nice to drop '|| die' and have REQUIRED_USE in games ebuilds
>>
>> OK to push?
>>
>> Thanks!
>>
>
> +1 for bumping
>
> but is this known to not break anything?

The easiest way to determine that is to remove the die from the eclass
and start bumping ebuilds to EAPI=4. Any issues can be addressed as
ebuilds are migrated.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [gentoo-dev] Re: [PATCH] games.eclass: allow EAPI=4
  2012-05-29 19:00 [gentoo-dev] [PATCH] games.eclass: allow EAPI=4 Sergei Trofimovich
  2012-05-29 19:36 ` hasufell
@ 2012-06-02  1:47 ` Mike Frysinger
  1 sibling, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2012-06-02  1:47 UTC (permalink / raw
  To: gentoo-dev; +Cc: games

[-- Attachment #1: Type: Text/Plain, Size: 205 bytes --]

On Tuesday 29 May 2012 15:00:15 Sergei Trofimovich wrote:
> Nice to drop '|| die' and have REQUIRED_USE in games ebuilds

we've already got:
	https://bugs.gentoo.org/336626

please collaborate there
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-02  1:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-29 19:00 [gentoo-dev] [PATCH] games.eclass: allow EAPI=4 Sergei Trofimovich
2012-05-29 19:36 ` hasufell
2012-05-29 20:00   ` Mike Gilbert
2012-06-02  1:47 ` [gentoo-dev] " Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox