public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
       [not found] <20120520123133.134892004B@flycatcher.gentoo.org>
@ 2012-05-20 12:33 ` Samuli Suominen
  2012-05-20 13:25   ` Michał Górny
                     ` (2 more replies)
  0 siblings, 3 replies; 18+ messages in thread
From: Samuli Suominen @ 2012-05-20 12:33 UTC (permalink / raw
  To: gentoo-dev, vapier

ChangeLog entries missing for every autotools.eclass modification today.

On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:
> vapier      12/05/20 12:31:33
>
>    Modified:             autotools.eclass
>    Log:
>    we don't use anything from eutils eclass now, so drop the inherit
>
> Revision  Changes    Path
> 1.134                eclass/autotools.eclass
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?rev=1.134&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?rev=1.134&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
>
> Index: autotools.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v
> retrieving revision 1.133
> retrieving revision 1.134
> diff -u -r1.133 -r1.134
> --- autotools.eclass	20 May 2012 10:39:45 -0000	1.133
> +++ autotools.eclass	20 May 2012 12:31:32 -0000	1.134
> @@ -1,6 +1,6 @@
>   # Copyright 1999-2012 Gentoo Foundation
>   # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v 1.133 2012/05/20 10:39:45 vapier Exp $
> +# $Header: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v 1.134 2012/05/20 12:31:32 vapier Exp $
>
>   # @ECLASS: autotools.eclass
>   # @MAINTAINER:
> @@ -16,7 +16,7 @@
>   if [[ ${___ECLASS_ONCE_AUTOTOOLS} != "recur -_+^+_- spank" ]] ; then
>   ___ECLASS_ONCE_AUTOTOOLS="recur -_+^+_- spank"
>
> -inherit eutils libtool
> +inherit libtool
>
>   # @ECLASS-VARIABLE: WANT_AUTOCONF
>   # @DESCRIPTION:
>
>
>
>




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
  2012-05-20 12:33 ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Samuli Suominen
@ 2012-05-20 13:25   ` Michał Górny
  2012-05-20 13:30     ` Nirbheek Chauhan
  2012-05-23 19:23     ` hasufell
  2012-05-20 14:32   ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Alec Warner
  2012-05-23  2:36   ` [gentoo-dev] " Ryan Hill
  2 siblings, 2 replies; 18+ messages in thread
From: Michał Górny @ 2012-05-20 13:25 UTC (permalink / raw
  To: gentoo-dev; +Cc: ssuominen, vapier

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

On Sun, 20 May 2012 15:33:11 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> ChangeLog entries missing for every autotools.eclass modification
> today.

I will repeat once again: autogenerate them.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
  2012-05-20 13:25   ` Michał Górny
@ 2012-05-20 13:30     ` Nirbheek Chauhan
  2012-05-20 13:55       ` Andreas K. Huettel
  2012-05-20 21:10       ` [gentoo-dev] Remove eclass/ChangeLog Markos Chandras
  2012-05-23 19:23     ` hasufell
  1 sibling, 2 replies; 18+ messages in thread
From: Nirbheek Chauhan @ 2012-05-20 13:30 UTC (permalink / raw
  To: gentoo-dev; +Cc: ssuominen, vapier

On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org> wrote:
> On Sun, 20 May 2012 15:33:11 +0300
> Samuli Suominen <ssuominen@gentoo.org> wrote:
>
>> ChangeLog entries missing for every autotools.eclass modification
>> today.
>
> I will repeat once again: autogenerate them.
>

+1 for this, seriously.

-- 
~Nirbheek Chauhan

Gentoo GNOME+Mozilla Team



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
  2012-05-20 13:30     ` Nirbheek Chauhan
@ 2012-05-20 13:55       ` Andreas K. Huettel
  2012-05-22  9:01         ` [gentoo-dev] Remove eclass/ChangeLog Michael Weber
  2012-05-20 21:10       ` [gentoo-dev] Remove eclass/ChangeLog Markos Chandras
  1 sibling, 1 reply; 18+ messages in thread
From: Andreas K. Huettel @ 2012-05-20 13:55 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: Text/Plain, Size: 679 bytes --]

Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org> wrote:
> > On Sun, 20 May 2012 15:33:11 +0300
> > 
> > Samuli Suominen <ssuominen@gentoo.org> wrote:
> >> ChangeLog entries missing for every autotools.eclass modification
> >> today.
> > 
> > I will repeat once again: autogenerate them.
> 
> +1 for this, seriously.

Yes please.

And forget about the difference between "user-oriented" and "dev-oriented". 
That's only an issue for people with too much time (also for debating).

-- 

Andreas K. Huettel
Gentoo Linux developer 
dilfridge@gentoo.org
http://www.akhuettel.de/


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
  2012-05-20 12:33 ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Samuli Suominen
  2012-05-20 13:25   ` Michał Górny
@ 2012-05-20 14:32   ` Alec Warner
  2012-05-23  2:36   ` [gentoo-dev] " Ryan Hill
  2 siblings, 0 replies; 18+ messages in thread
From: Alec Warner @ 2012-05-20 14:32 UTC (permalink / raw
  To: gentoo-dev

On Sun, May 20, 2012 at 2:33 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> ChangeLog entries missing for every autotools.eclass modification today.

I'm sure spankman would make them if his tools did it for him, RIGHT SPANK?

-A

>
> On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:
>>
>> vapier      12/05/20 12:31:33
>>
>>   Modified:             autotools.eclass
>>   Log:
>>   we don't use anything from eutils eclass now, so drop the inherit
>>
>> Revision  Changes    Path
>> 1.134                eclass/autotools.eclass
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?rev=1.134&view=markup
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?rev=1.134&content-type=text/plain
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
>>
>> Index: autotools.eclass
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v
>> retrieving revision 1.133
>> retrieving revision 1.134
>> diff -u -r1.133 -r1.134
>> --- autotools.eclass    20 May 2012 10:39:45 -0000      1.133
>> +++ autotools.eclass    20 May 2012 12:31:32 -0000      1.134
>> @@ -1,6 +1,6 @@
>>  # Copyright 1999-2012 Gentoo Foundation
>>  # Distributed under the terms of the GNU General Public License v2
>> -# $Header: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v 1.133
>> 2012/05/20 10:39:45 vapier Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/eclass/autotools.eclass,v 1.134
>> 2012/05/20 12:31:32 vapier Exp $
>>
>>  # @ECLASS: autotools.eclass
>>  # @MAINTAINER:
>> @@ -16,7 +16,7 @@
>>  if [[ ${___ECLASS_ONCE_AUTOTOOLS} != "recur -_+^+_- spank" ]] ; then
>>  ___ECLASS_ONCE_AUTOTOOLS="recur -_+^+_- spank"
>>
>> -inherit eutils libtool
>> +inherit libtool
>>
>>  # @ECLASS-VARIABLE: WANT_AUTOCONF
>>  # @DESCRIPTION:
>>
>>
>>
>>
>
>



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog
  2012-05-20 13:30     ` Nirbheek Chauhan
  2012-05-20 13:55       ` Andreas K. Huettel
@ 2012-05-20 21:10       ` Markos Chandras
  1 sibling, 0 replies; 18+ messages in thread
From: Markos Chandras @ 2012-05-20 21:10 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 05/20/2012 02:30 PM, Nirbheek Chauhan wrote:
> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
> wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>> 
>>> ChangeLog entries missing for every autotools.eclass
>>> modification today.
>> 
>> I will repeat once again: autogenerate them.
>> 
> 
> +1 for this, seriously.
> 
Who will do it? Infra? Maybe we should ask them first?

- -- 
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBCgAGBQJPuV3LAAoJEPqDWhW0r/LC1oEQAJmoSSWRnVysFmj6mknwSEoc
GsIxnB6igUdHPFpnxrJXsKzmUvPcRPTboL9H7IOFTBr6lSP8lgEZCaPzpvQQLnTE
cvKvOjmjh/5bhAPz8zu6ZRo+XvF9hFhBLyY//G/ljwnijwx5gSpyKMi4hiPg0Rb5
sl6gUaRepess8F1bqZZ7DeR1/IA1hyw2GlJ99F76opKa/uc7RVAUJClZTfjep8An
9khfIGCwSjC8f86qRWwTTu7qePk969gSoFcDpxEEn94gQpNPqRlX3jqEPJgh64fQ
nYVl/0Lao/u0XAqNmTkbfu7ebf4WHfbbtzPrpzpQvsfb/F376nn5UFpRPhyYAIcE
cmyGuuWzGbgSr88HilzyAkHGXZW9Q6qy5B6y4wqSLxJD4/BLMnH3rXceIrHlpfpG
yHsPurgiHa2VZ5AE9n8IvH74Nf4fDS6JpLsdzJWH6jFhUaanxY6i5hg1ixdPJ1p1
0+3xFBepa0Wm7NNy/JpSbv4NWAqrrUFwdJJO2XczIgYUnJgqwMDExtM3/15LEJVh
aRSnC3Zq9EIBN0NNW6U3QFYigL/j93XONr4j9eU2BrrbaTuavXebljNQuUt6WVvY
lTtEAlTmXOPrizRsI+rfeCd27VrDHjHadGPt9wSZi7hYyhWGnRRepOJKvyhO6yP1
0GiA450pJcbI0mNEYzJq
=QHna
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog
  2012-05-20 13:55       ` Andreas K. Huettel
@ 2012-05-22  9:01         ` Michael Weber
  2012-05-22  9:22           ` Fabio Erculiani
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Weber @ 2012-05-22  9:01 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>> wrote:
>>> I will repeat once again: autogenerate them.
>> 
>> +1 for this, seriously.

+1 and consider profiles/**/package.mask, too.

- -- 
- --
Gentoo Dev
http://xmw.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAk+7VfAACgkQknrdDGLu8JAClQD/SVh+bstPurUReBipvCeGPYfE
ZIGHcSs8Wt7HH0dy/YcA/iB2TRcd3BlcVy4O6v5wmf52s4UtCNnpYOL+RpD3O/in
=uZ6k
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog
  2012-05-22  9:01         ` [gentoo-dev] Remove eclass/ChangeLog Michael Weber
@ 2012-05-22  9:22           ` Fabio Erculiani
  2012-05-22  9:35             ` Git migration (2012) (Was: Re: [gentoo-dev] Remove eclass/ChangeLog) Pacho Ramos
  0 siblings, 1 reply; 18+ messages in thread
From: Fabio Erculiani @ 2012-05-22  9:22 UTC (permalink / raw
  To: gentoo-dev

On Tue, May 22, 2012 at 11:01 AM, Michael Weber <xmw@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
>> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>>> wrote:
>>>> I will repeat once again: autogenerate them.
>>>
>>> +1 for this, seriously.
>
> +1 and consider profiles/**/package.mask, too.

and how about getting rid of echangelog and just have it autogenerated as well?
Or even better, how about giving up with cvs once for all?

>
> - --
> - --
> Gentoo Dev
> http://xmw.de/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iF4EAREIAAYFAk+7VfAACgkQknrdDGLu8JAClQD/SVh+bstPurUReBipvCeGPYfE
> ZIGHcSs8Wt7HH0dy/YcA/iB2TRcd3BlcVy4O6v5wmf52s4UtCNnpYOL+RpD3O/in
> =uZ6k
> -----END PGP SIGNATURE-----
>



-- 
Fabio Erculiani



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Git migration (2012) (Was: Re: [gentoo-dev] Remove eclass/ChangeLog)
  2012-05-22  9:22           ` Fabio Erculiani
@ 2012-05-22  9:35             ` Pacho Ramos
  2012-05-22  9:46               ` Dirkjan Ochtman
  0 siblings, 1 reply; 18+ messages in thread
From: Pacho Ramos @ 2012-05-22  9:35 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

El mar, 22-05-2012 a las 11:22 +0200, Fabio Erculiani escribió:
> On Tue, May 22, 2012 at 11:01 AM, Michael Weber <xmw@gentoo.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
> >> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
> >>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
> >>> wrote:
> >>>> I will repeat once again: autogenerate them.
> >>>
> >>> +1 for this, seriously.
> >
> > +1 and consider profiles/**/package.mask, too.
> 
> and how about getting rid of echangelog and just have it autogenerated as well?
> Or even better, how about giving up with cvs once for all?
> 

Regarding migration to git, I think some people where working on it, but
there were some pending problems preventing the migration:
https://bugs.gentoo.org/show_bug.cgi?id=333531

there, you can see the blockers, the problem is that most of them are
stalled :|, if you (or anybody) could take care of them... 



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: Git migration (2012) (Was: Re: [gentoo-dev] Remove eclass/ChangeLog)
  2012-05-22  9:35             ` Git migration (2012) (Was: Re: [gentoo-dev] Remove eclass/ChangeLog) Pacho Ramos
@ 2012-05-22  9:46               ` Dirkjan Ochtman
  0 siblings, 0 replies; 18+ messages in thread
From: Dirkjan Ochtman @ 2012-05-22  9:46 UTC (permalink / raw
  To: gentoo-dev

On Tue, May 22, 2012 at 11:35 AM, Pacho Ramos <pacho@gentoo.org> wrote:
> Regarding migration to git, I think some people where working on it, but
> there were some pending problems preventing the migration:
> https://bugs.gentoo.org/show_bug.cgi?id=333531
>
> there, you can see the blockers, the problem is that most of them are
> stalled :|, if you (or anybody) could take care of them...

ISTM things like bug 333697 (partial checkout support) and 333699
(git-cvsserver, so that holdouts can still commit through CVS?)
shouldn't block the migration... they're just nice-to-haves.

Cheers,

Dirkjan



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [gentoo-dev] Re: Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass)
  2012-05-20 12:33 ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Samuli Suominen
  2012-05-20 13:25   ` Michał Górny
  2012-05-20 14:32   ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Alec Warner
@ 2012-05-23  2:36   ` Ryan Hill
  2012-05-23  8:02     ` [gentoo-dev] Re: Remove eclass/ChangeLog Samuli Suominen
  2 siblings, 1 reply; 18+ messages in thread
From: Ryan Hill @ 2012-05-23  2:36 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

On Sun, 20 May 2012 15:33:11 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> ChangeLog entries missing for every autotools.eclass modification today.
> 
> On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:
> > vapier      12/05/20 12:31:33

One person doesn't do entries.  OMG let's remove it!


-- 
fonts, gcc-porting
toolchain, wxwidgets
@ gentoo.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Re: Remove eclass/ChangeLog
  2012-05-23  2:36   ` [gentoo-dev] " Ryan Hill
@ 2012-05-23  8:02     ` Samuli Suominen
  2012-05-23 16:29       ` Rich Freeman
  2012-05-24  4:05       ` Ryan Hill
  0 siblings, 2 replies; 18+ messages in thread
From: Samuli Suominen @ 2012-05-23  8:02 UTC (permalink / raw
  To: gentoo-dev

On 05/23/2012 05:36 AM, Ryan Hill wrote:
> On Sun, 20 May 2012 15:33:11 +0300
> Samuli Suominen<ssuominen@gentoo.org>  wrote:
>
>> ChangeLog entries missing for every autotools.eclass modification today.
>>
>> On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:
>>> vapier      12/05/20 12:31:33
>
> One person doesn't do entries.  OMG let's remove it!
>
>

absolutely because inconsitency renderess the file useless



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Re: Remove eclass/ChangeLog
  2012-05-23  8:02     ` [gentoo-dev] Re: Remove eclass/ChangeLog Samuli Suominen
@ 2012-05-23 16:29       ` Rich Freeman
  2012-05-23 16:46         ` Michał Górny
  2012-05-24  4:05       ` Ryan Hill
  1 sibling, 1 reply; 18+ messages in thread
From: Rich Freeman @ 2012-05-23 16:29 UTC (permalink / raw
  To: gentoo-dev

On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>> One person doesn't do entries.  OMG let's remove it!
>>
>
> absolutely because inconsitency renderess the file useless
>

Well, for now the solution is to enforce following policy.

For the future, perhaps the policy's time has ended.  Sure, Changelogs
can be handy, but they are increasingly redundant and scm comments
have the potential to be far more useful.  By all means require
meaningful scm commit comments, but if Changelog files are holding us
back either auto-generate them or ditch them.

And, to add my own to cents to this chain about the only thing worse
than failing to directly inherit an eclass dependency is to break the
tree fixing the problem on personal initiative.  When a dev messes up
the solution is to talk to them or if necessary talk to devrel/QA -
not to break end-user systems.

Rich



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Re: Remove eclass/ChangeLog
  2012-05-23 16:29       ` Rich Freeman
@ 2012-05-23 16:46         ` Michał Górny
  2012-05-23 18:29           ` Markos Chandras
  0 siblings, 1 reply; 18+ messages in thread
From: Michał Górny @ 2012-05-23 16:46 UTC (permalink / raw
  To: gentoo-dev; +Cc: rich0

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Wed, 23 May 2012 12:29:34 -0400
Rich Freeman <rich0@gentoo.org> wrote:

> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen
> <ssuominen@gentoo.org> wrote:
> > On 05/23/2012 05:36 AM, Ryan Hill wrote:
> >> One person doesn't do entries.  OMG let's remove it!
> >>
> >
> > absolutely because inconsitency renderess the file useless
> >
> 
> Well, for now the solution is to enforce following policy.
> 
> For the future, perhaps the policy's time has ended.  Sure, Changelogs
> can be handy, but they are increasingly redundant and scm comments
> have the potential to be far more useful.  By all means require
> meaningful scm commit comments, but if Changelog files are holding us
> back either auto-generate them or ditch them.

ChangeLogs could be fine for ebuilds. But for more broad cases like
eclasses, one can usually have a set of changes prepared for commit.
With CVS, it's PITA but with git it's already much better. Of course,
it all fails if every commit has to update a randomly changed, shared
file called ChangeLog...

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Re: Remove eclass/ChangeLog
  2012-05-23 16:46         ` Michał Górny
@ 2012-05-23 18:29           ` Markos Chandras
  0 siblings, 0 replies; 18+ messages in thread
From: Markos Chandras @ 2012-05-23 18:29 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 05/23/2012 05:46 PM, Michał Górny wrote:
> On Wed, 23 May 2012 12:29:34 -0400 Rich Freeman <rich0@gentoo.org>
> wrote:
> 
>> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen 
>> <ssuominen@gentoo.org> wrote:
>>> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>>>> One person doesn't do entries.  OMG let's remove it!
>>>> 
>>> 
>>> absolutely because inconsitency renderess the file useless
>>> 
>> 
>> Well, for now the solution is to enforce following policy.
>> 
>> For the future, perhaps the policy's time has ended.  Sure,
>> Changelogs can be handy, but they are increasingly redundant and
>> scm comments have the potential to be far more useful.  By all
>> means require meaningful scm commit comments, but if Changelog
>> files are holding us back either auto-generate them or ditch
>> them.
> 
> ChangeLogs could be fine for ebuilds. But for more broad cases
> like eclasses, one can usually have a set of changes prepared for
> commit. With CVS, it's PITA but with git it's already much better.
> Of course, it all fails if every commit has to update a randomly
> changed, shared file called ChangeLog...
> 

So we did we introduce changelogs for eclass/ in the first place if
everyone is happy with getting rid of them?

- -- 
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBCgAGBQJPvSyUAAoJEPqDWhW0r/LCrp0QAIwYhxeO5qeYaCrh3B7WCd3X
pt8cMAquC38VOIjfd+Lz+iG2+8ftYb1s5xQu52F6zZEkbwxCLmYBKJrnpNljSm8T
QAmB4xXg4vKxjpwAyc+fOev53HZdQyzav36m1DhOEXZKixI+OR1MplZ55VlEAT0+
wRPJj9+WsiTMONRkuukCCJtvnY1kDjJLtjNDzUA4QSxh+pgcgAPGoDMh5nL706h5
KW5/jBTW01+oEWyBosXxBUoX8p2/FvAG1Meib0BbEBdsyrYdQSDJK2xMjK0JJ7PH
QhOeA2NameaFA1YzvebB7KDNSGB3zMm1TdnYmhfU1jmWImyB1BQvdFT37KcvZagQ
WhErwHxDojz27lhiCHY95nPDATMxxiC61WdBLoByV93xRAqwnpeSva26hV1Nv552
n3nZ5DWCKRF+qSSEo1Oz3DCtDxV5ygyOw8iHOhqhZ5IcuNIchfYgss/dCFRRy3zy
uN8l/wge7J0MjOVKBnpT9nWmmwhB4pD+o3Avq2OBwuDrqAW7iYKkTPzQwsIq7ZGI
HTvtMhOrULIkm/2c77FGXdFwJWMPueroUe4LntY/0c2l30P2Fafe0sEp5yCjzCeA
uXwWC0iWTPuVBYGFJQ5iZqB3X+LAVWz2HLpqZRJ9qW4X3QXSuXsrr5wdAukjAUCu
8qMUNncYeLeHvdeazWey
=/lXi
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog
  2012-05-20 13:25   ` Michał Górny
  2012-05-20 13:30     ` Nirbheek Chauhan
@ 2012-05-23 19:23     ` hasufell
  2012-05-23 19:46       ` Ian Stakenvicius
  1 sibling, 1 reply; 18+ messages in thread
From: hasufell @ 2012-05-23 19:23 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/20/2012 03:25 PM, Michał Górny wrote:
> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
> <ssuominen@gentoo.org> wrote:
> 
>> ChangeLog entries missing for every autotools.eclass
>> modification today.
> 
> I will repeat once again: autogenerate them.
> 

+1

I think it is nice to be able to use a different changelog entry than
commit message, but autogenerated entries would be more consistent.

Having ChangeLog files at all is just a convenience, but an important
one imo. It's the quickest way to track down sudden breakage.

scm comments are _not_ the same as a single file holding information
on all changes to an entire directory.


As for the given case I demand that the missing ChangeLog entries will
be added now by vapier, cause it seems they have already caused
breakage: #417265
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPvTkrAAoJEFpvPKfnPDWzG5UIAIKFaGAXYGiyLBwbeQ1QxdlD
wndZJIXN9pWwDU/F3uyKqmHqNC1Aqf7U7g88ue/1FhSSyJeG+rEH1Qmym0Eb3fIe
hECZKWHMV/CDe2VhgGZ+dKvq3Pxz/nGt994NurLbBRWPCY2md63M45+499gb32w0
5wpYcH8vXw/noHvfw4o77Pwzu+5yphDWycOFtrc/UWIK0NXQZLzalnYqwl2HjHKE
vRWn/eAcTL+TzkS/pM7RI4BCROl3Rmk+jmkgeIOAlVlcpYEa41FB5wv7t3HdGM3i
AWiQySQ8iKehH4Blr97czn30hqekI6ACD08hEhiFZeA7JJYRT4ziYS1lapBzGFk=
=u07L
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [gentoo-dev] Remove eclass/ChangeLog
  2012-05-23 19:23     ` hasufell
@ 2012-05-23 19:46       ` Ian Stakenvicius
  0 siblings, 0 replies; 18+ messages in thread
From: Ian Stakenvicius @ 2012-05-23 19:46 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 23/05/12 03:23 PM, hasufell wrote:
> On 05/20/2012 03:25 PM, Michał Górny wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen 
>> <ssuominen@gentoo.org> wrote:
> 
>>> ChangeLog entries missing for every autotools.eclass 
>>> modification today.
> 
>> I will repeat once again: autogenerate them.
> 
> 


Isn't one of the reasons the changelog is there, is so that eclass
changes can be committed with repoman and (with the newer repoman) the
- -m comment will automatically be added to the ChangeLog ??


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iF4EAREIAAYFAk+9Pn0ACgkQ2ugaI38ACPCtogEAh1/FLYMho2HaSyg7e6JDtwcW
UTAPNaD3WPFGyJbO/ZMA/0gh1Ale/msPdzlJyYBny6rDtCjkUNCAP2zwwk+KXV5R
=tdxA
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [gentoo-dev] Re: Remove eclass/ChangeLog
  2012-05-23  8:02     ` [gentoo-dev] Re: Remove eclass/ChangeLog Samuli Suominen
  2012-05-23 16:29       ` Rich Freeman
@ 2012-05-24  4:05       ` Ryan Hill
  1 sibling, 0 replies; 18+ messages in thread
From: Ryan Hill @ 2012-05-24  4:05 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On Wed, 23 May 2012 11:02:58 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> On 05/23/2012 05:36 AM, Ryan Hill wrote:

> > One person doesn't do entries.  OMG let's remove it!

> absolutely because inconsitency renderess the file useless

Perfect is the enemy of good enough.  Stuck in a cabin for the weekend
without cvs access, it was handy enough for me.

When we switch to git 4-8 years from now, then yes, kill it.  Until then,
leave it alone please.


-- 
fonts, gcc-porting
toolchain, wxwidgets
@ gentoo.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2012-05-24  3:58 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20120520123133.134892004B@flycatcher.gentoo.org>
2012-05-20 12:33 ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Samuli Suominen
2012-05-20 13:25   ` Michał Górny
2012-05-20 13:30     ` Nirbheek Chauhan
2012-05-20 13:55       ` Andreas K. Huettel
2012-05-22  9:01         ` [gentoo-dev] Remove eclass/ChangeLog Michael Weber
2012-05-22  9:22           ` Fabio Erculiani
2012-05-22  9:35             ` Git migration (2012) (Was: Re: [gentoo-dev] Remove eclass/ChangeLog) Pacho Ramos
2012-05-22  9:46               ` Dirkjan Ochtman
2012-05-20 21:10       ` [gentoo-dev] Remove eclass/ChangeLog Markos Chandras
2012-05-23 19:23     ` hasufell
2012-05-23 19:46       ` Ian Stakenvicius
2012-05-20 14:32   ` [gentoo-dev] Remove eclass/ChangeLog (was: Re: [gentoo-commits] gentoo-x86 commit in eclass: autotools.eclass) Alec Warner
2012-05-23  2:36   ` [gentoo-dev] " Ryan Hill
2012-05-23  8:02     ` [gentoo-dev] Re: Remove eclass/ChangeLog Samuli Suominen
2012-05-23 16:29       ` Rich Freeman
2012-05-23 16:46         ` Michał Górny
2012-05-23 18:29           ` Markos Chandras
2012-05-24  4:05       ` Ryan Hill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox