public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] epatch: splitting out common options from user-specific ones
Date: Wed, 18 Apr 2012 14:03:07 -0400	[thread overview]
Message-ID: <201204181403.07937.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

it isn't uncommon for people to want to force the patch (-p#) or fuzz (-f#) 
level when applying specific patches.  but it is unusual that they want to kill 
off the extra options: -g0 -E --no-backup-if-mismatch.  so i'd like to split 
these off and improve the epatch API.

# Extra options to pass to `patch` (such as -p1).
EPATCH_OPTS=""
# Common options to pass to `patch` (you probably shouldn't need
# to change these at all).
EPATCH_COMMON_OPTS="-g0 -E --no-backup-if-mismatch"

and then i'll try to extend `epatch` so the first set of arguments can 
implicitly set EPATCH_OPTS for that one patch:
	epatch -p1 "${FILESDIR}"/${P}-foo.patch
this is much nicer than the current:
	EPATCH_OPTS="-p1" epatch "${FILESDIR}"/${P}-foo.patch

i can't see this causing any issues, but considering everyone uses `epatch`, 
best to ask first.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2012-04-18 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 18:03 Mike Frysinger [this message]
2012-04-20  3:24 ` [gentoo-dev] epatch: splitting out common options from user-specific ones Mike Frysinger
2012-04-20  3:38   ` Mike Frysinger
     [not found] <iRHui-2kD-3@gated-at.bofh.it>
2012-04-20 19:38 ` Leho Kraav
2012-04-20 19:54   ` Leho Kraav
2012-04-20 19:59   ` Mike Frysinger
2012-04-20 20:06     ` Leho Kraav
2012-04-20 21:40       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204181403.07937.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox