From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SJQ2C-00084u-DQ for garchives@archives.gentoo.org; Sun, 15 Apr 2012 14:02:32 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D5FAE0BE5; Sun, 15 Apr 2012 14:02:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 1189FE094A for ; Sun, 15 Apr 2012 14:01:37 +0000 (UTC) Received: from pomiocik.lan (87-205-54-245.adsl.inetia.pl [87.205.54.245]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 6333A1B4001; Sun, 15 Apr 2012 14:01:36 +0000 (UTC) Date: Sun, 15 Apr 2012 16:01:50 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: dirtyepic@gentoo.org Subject: Re: [gentoo-dev] Making user patches globally available Message-ID: <20120415160150.6815e135@pomiocik.lan> In-Reply-To: <20120415021641.1858ffde@gentoo.org> References: <20120415021641.1858ffde@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/0BvNJ_KPNr.MAg8J5yriHPk"; protocol="application/pgp-signature" X-Archives-Salt: d62f8440-47a4-4574-b5f7-47a24cc48771 X-Archives-Hash: 833c0a1b061d4693415fb797245f52e1 --Sig_/0BvNJ_KPNr.MAg8J5yriHPk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 15 Apr 2012 02:16:41 -0600 Ryan Hill wrote: > Right now we have support in some packages for user patches - those > being patches dropped into /etc/portage/patches/pkgname/ - which are > automatically applied. Because this feature is implemented by > epatch_user() in eutils.eclass, it is only available for ebuilds that > inherit eutils and explicitly call epatch_user or inherit another > eclass that calls it in an exported phase (eg. base). The end result > is a very inconsistent experience, where user patches may or may not > work not only on a package-by-package basis, but ebuild-by-ebuild. That's why we should work on spreading the use of base eclass or one of similar eclasses rather than reinventing the wheel. On the other hand, taking into consideration that base.eclass is a pretty roughly shaped wheel we could consider creating a new base eclass for that. > Is there any reason why this couldn't just be done in the package > manager, making user patches available for all ebuilds without code > changes? It should have been done there in the first place. But it hasn't, and this has some advantages. For example, thanks to complete control over the moment where epatch_user() is called, autotools-utils is able to smartly do autoreconf when needed. If user patches were forced to be PM-only feature, there would be no good way of doing that. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/0BvNJ_KPNr.MAg8J5yriHPk Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iJwEAQEIAAYFAk+K1M8ACgkQfXuS5UK5QB0qJgP/eYlgy9X4YV+KAD3dFUFB8pT5 YHb2ZE55zrNoaoLsavzzpVGKk8okqJ+G0K05P8zQdXhMEsD1QmQOyci0IMZgLEEv 6AziFzX/oryRnQy1AihqK8L7tImrnPQWBhqPfVO6r9TuWfZiOQhkWnrPUSH6PI8Z Fz4+nDCu9bcPDFWSoEE= =pPS2 -----END PGP SIGNATURE----- --Sig_/0BvNJ_KPNr.MAg8J5yriHPk--