From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SJLeC-00072S-7F for garchives@archives.gentoo.org; Sun, 15 Apr 2012 09:21:28 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 89B1FE0ACF; Sun, 15 Apr 2012 09:21:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B5EE6E09F8 for ; Sun, 15 Apr 2012 09:20:40 +0000 (UTC) Received: from sf.home (unknown [178.125.209.84]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 640F91B4022 for ; Sun, 15 Apr 2012 09:20:39 +0000 (UTC) Date: Sun, 15 Apr 2012 12:25:12 +0300 From: Sergei Trofimovich To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Making user patches globally available Message-ID: <20120415122512.6331f11b@sf.home> In-Reply-To: <4F8A8C70.5070009@gentoo.org> References: <20120415021641.1858ffde@gentoo.org> <4F8A8C70.5070009@gentoo.org> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/mormSl6md0wDJ8.efwnWk.a"; protocol="application/pgp-signature" X-Archives-Salt: b9306db6-c8a6-4d38-93c6-86a2930073b0 X-Archives-Hash: 3dbb6b521edef046e5d3105e179338a8 --Sig_/mormSl6md0wDJ8.efwnWk.a Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 15 Apr 2012 16:53:04 +0800 Patrick Lauer wrote: > On 04/15/12 16:16, Ryan Hill wrote: > > Right now we have support in some packages for user patches - those bei= ng > > patches dropped into /etc/portage/patches/pkgname/ - which are automati= cally > > applied. Because this feature is implemented by epatch_user() in > > eutils.eclass, it is only available for ebuilds that inherit eutils and > > explicitly call epatch_user or inherit another eclass that calls it in = an > > exported phase (eg. base). The end result is a very inconsistent exper= ience, > > where user patches may or may not work not only on a package-by-package > > basis, but ebuild-by-ebuild. > >=20 > > Is there any reason why this couldn't just be done in the package manag= er, > > making user patches available for all ebuilds without code changes? > >=20 >=20 > From a debugging / bug wrangling perspective it's bad because there's no > way for me to see if someone accidentally patched in something > unexpected. (And we do have creative users :) ) >=20 > It's a neat feature, but I'm moderately opposed to it unless we can get > reporting in place so I can definitely see (e.g. from a logfile or error > message) that there's been some ebuild modifications. For an advanced user it's already just a matter of adding post_src_prepare() { epatch_user } to '/etc/portage/bashrc' and screw thing up, right? eutils.eclass:epatch_user() could be more noisy (ewarn?) when applies user patches. That way you could easier see something odd happening in build.log. --=20 Sergei --Sig_/mormSl6md0wDJ8.efwnWk.a Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iEYEARECAAYFAk+KlAUACgkQcaHudmEf86p4PwCfcHhWiTdKJEuNis2BqaqgEIpN N48AnRqAgwbwXdcp8ALzgaaWqWFI8Ygv =f8ZC -----END PGP SIGNATURE----- --Sig_/mormSl6md0wDJ8.efwnWk.a--