From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SJLFn-0002KC-Aa for garchives@archives.gentoo.org; Sun, 15 Apr 2012 08:56:16 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5D996E0AD7; Sun, 15 Apr 2012 08:55:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 202BBE0AA6 for ; Sun, 15 Apr 2012 08:54:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id AB7F81B4087 for ; Sun, 15 Apr 2012 08:54:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -2.94 X-Spam-Level: X-Spam-Status: No, score=-2.94 tagged_above=-999 required=5.5 tests=[AWL=-1.028, BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0lpa5aMRotES for ; Sun, 15 Apr 2012 08:54:53 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id ECDB71B407B for ; Sun, 15 Apr 2012 08:54:52 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SJLEN-0007US-3x for gentoo-dev@gentoo.org; Sun, 15 Apr 2012 10:54:47 +0200 Received: from 71-17-69-121.yktn.hsdb.sasknet.sk.ca ([71.17.69.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Apr 2012 10:54:47 +0200 Received: from dirtyepic by 71-17-69-121.yktn.hsdb.sasknet.sk.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Apr 2012 10:54:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: Making user patches globally available Date: Sun, 15 Apr 2012 03:03:26 -0600 Message-ID: <20120415030326.0355ecf2@gentoo.org> References: <20120415021641.1858ffde@gentoo.org> <4F8A885C.3050508@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/l2r3JIHgoCsnQnfSB7WX..z"; protocol="application/pgp-signature" X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 71-17-69-121.yktn.hsdb.sasknet.sk.ca X-Newsreader: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) X-Archives-Salt: a68668bc-da76-4b0e-a305-e5d12b9c3f2c X-Archives-Hash: ed43c631899c013c042d20b1b572cdce --Sig_/l2r3JIHgoCsnQnfSB7WX..z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 15 Apr 2012 01:35:40 -0700 Zac Medico wrote: > On 04/15/2012 01:16 AM, Ryan Hill wrote: > > Right now we have support in some packages for user patches - those bei= ng > > patches dropped into /etc/portage/patches/pkgname/ - which are automati= cally > > applied. Because this feature is implemented by epatch_user() in > > eutils.eclass, it is only available for ebuilds that inherit eutils and > > explicitly call epatch_user or inherit another eclass that calls it in = an > > exported phase (eg. base). The end result is a very inconsistent exper= ience, > > where user patches may or may not work not only on a package-by-package > > basis, but ebuild-by-ebuild. > >=20 > > Is there any reason why this couldn't just be done in the package manag= er, > > making user patches available for all ebuilds without code changes? >=20 > Funtoo has support for FEATURES=3Dlocalpatch, which does the epatch_user > thing before src_prepare. I think it should really go after src_prepare, > in order to apply patches after those that src_prepare may apply > (avoiding possible conflicts). I agree. > The reason that Funtoo's FEATURES=3Dlocalpatch applies patches before > src_prepare is that it's common for eautoreconf to be called inside > src_prepare, and applying patches after src_prepare can create a need to > call eautoreconf a second time. Well that could waste a bit of time but is pretty much harmless, no? And t= he existing usages of epatch_user (other than autotools-utils) don't eautoreco= nf anyways, nor should they in case the package doesn't use autotools. --=20 fonts, gcc-porting toolchain, wxwidgets @ gentoo.org --Sig_/l2r3JIHgoCsnQnfSB7WX..z Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAk+Kjt4ACgkQiqiDRvmkBmImrACgpdri4Bdz9f9fI+8yUkVPKbTL 5i8AoJl1ZRV7SgkO9K60T9x1TXlmkurG =vi0z -----END PGP SIGNATURE----- --Sig_/l2r3JIHgoCsnQnfSB7WX..z--