* Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
2012-02-22 17:33 ` Matthew Summers
@ 2012-02-22 17:38 ` Fabian Groffen
2012-02-22 18:40 ` Mike Gilbert
2012-02-22 18:43 ` Justin
2 siblings, 0 replies; 6+ messages in thread
From: Fabian Groffen @ 2012-02-22 17:38 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On 22-02-2012 11:33:55 -0600, Matthew Summers wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
> > Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
[snip]
> >> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
> >> + env LC_ALL=C svn info \
> >> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
> >> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
> >> }
> >>
> >> ## -- subversion__get_repository_uri()
> >> --------------------------------------- #
> >
> > I'm not an expert of the subversion eclass, but the diff looks good.
>
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.
I've seen some projects that have a "anonymous" or "guest" user with a
trivial/documented password, so I guess it's for cases like those.
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
2012-02-22 17:33 ` Matthew Summers
2012-02-22 17:38 ` Fabian Groffen
@ 2012-02-22 18:40 ` Mike Gilbert
2012-02-22 18:43 ` Justin
2 siblings, 0 replies; 6+ messages in thread
From: Mike Gilbert @ 2012-02-22 18:40 UTC (permalink / raw
To: gentoo-dev
On Wed, Feb 22, 2012 at 12:33 PM, Matthew Summers
<quantumsummers@gentoo.org> wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
>> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
>>> Hi,
>>>
>>> any objections against following patch for subversion.eclass?
>>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
>>> reemerge of a package.
>>>
>>>
>>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
>>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
>>> @@ -469,7 +469,9 @@
>>> local target="${1}"
>>> local key="${2}"
>>>
>>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> + env LC_ALL=C svn info \
>>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
>>> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> }
>>>
>>> ## -- subversion__get_repository_uri()
>>> --------------------------------------- #
>>
>> I'm not an expert of the subversion eclass, but the diff looks good.
>>
>> --
>> Gilles Dartiguelongue <eva@gentoo.org>
>> Gentoo
>
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.
I think the intended usage is by the user on the command line, or in a
package.env file.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
2012-02-22 17:33 ` Matthew Summers
2012-02-22 17:38 ` Fabian Groffen
2012-02-22 18:40 ` Mike Gilbert
@ 2012-02-22 18:43 ` Justin
2 siblings, 0 replies; 6+ messages in thread
From: Justin @ 2012-02-22 18:43 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
On 22.02.2012 18:33, Matthew Summers wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
>> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
>>> Hi,
>>>
>>> any objections against following patch for subversion.eclass?
>>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
>>> reemerge of a package.
>>>
>>>
>>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
>>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
>>> @@ -469,7 +469,9 @@
>>> local target="${1}"
>>> local key="${2}"
>>>
>>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> + env LC_ALL=C svn info \
>>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
>>> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> }
>>>
>>> ## -- subversion__get_repository_uri()
>>> --------------------------------------- #
>>
>> I'm not an expert of the subversion eclass, but the diff looks good.
>>
>> --
>> Gilles Dartiguelongue <eva@gentoo.org>
>> Gentoo
>
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.
>
This one for example
http://rapidsvn.tigris.org/
Quote:
Now you can checkout the source code for RapidSVN with RapidSVN
(Repository->Checkout) or with the svn command-line client.
The URL for the latest code is:
http://rapidsvn.tigris.org/svn/rapidsvn/trunk
You will be prompted for username and password.
For read access enter "guest" with an empty password.
justin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread