From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-49883-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1S0G9l-0003HM-IR
	for garchives@archives.gentoo.org; Wed, 22 Feb 2012 17:39:13 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 49EA8E12C5;
	Wed, 22 Feb 2012 17:38:58 +0000 (UTC)
Received: from amun.cheops.ods.org (amun.cheops.ods.org [83.161.135.166])
	by pigeon.gentoo.org (Postfix) with ESMTP id 0D7A0E12AE
	for <gentoo-dev@lists.gentoo.org>; Wed, 22 Feb 2012 17:38:25 +0000 (UTC)
Received: from nut.cheops.ods.org ([172.17.2.83] helo=gentoo.org)
	by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.77)
	(envelope-from <grobian@gentoo.org>)
	id 1S0G93-0006a0-41
	for gentoo-dev@lists.gentoo.org; Wed, 22 Feb 2012 18:38:26 +0100
Date: Wed, 22 Feb 2012 18:38:47 +0100
From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
Message-ID: <20120222173847.GA944@gentoo.org>
Mail-Followup-To: gentoo-dev@lists.gentoo.org
References: <4F40D7C3.1070906@gentoo.org>
 <1329862452.25132.0.camel@keitaro>
 <CAET+hMTXnB+7+RqHWRWDka2FbKDBds_5j6pfOTx4LdMPZsoaZQ@mail.gmail.com>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jwSnfOBD38i7UC9C"
Content-Disposition: inline
In-Reply-To: <CAET+hMTXnB+7+RqHWRWDka2FbKDBds_5j6pfOTx4LdMPZsoaZQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (Darwin 11.3.0, VIM - Vi IMproved 7.3)
Organization: Gentoo Foundation, Inc.
X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV
X-Archives-Salt: 560520fe-fbcd-4d0d-95d9-be72d512edb8
X-Archives-Hash: a8508700dbcaf793d9316e2837514307


--jwSnfOBD38i7UC9C
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 22-02-2012 11:33:55 -0600, Matthew Summers wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> w=
rote:
> > Le dimanche 19 f=C3=A9vrier 2012 =C3=A0 12:06 +0100, Justin a =C3=A9cri=
t :
[snip]
> >> - =C2=A0 =C2=A0 env LC_ALL=3DC svn info "${target}" | grep -i "^${key}=
" | cut -d" " -f2-
> >> + =C2=A0 =C2=A0 env LC_ALL=3DC svn info \
> >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${options} --username "${E=
SVN_USER}" --password "${ESVN_PASSWORD}" \
> >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "${target}" | grep -i "^${=
key}" | cut -d" " -f2-
> >> =C2=A0}
> >>
> >> =C2=A0## -- subversion__get_repository_uri()
> >> --------------------------------------- #
> >
> > I'm not an expert of the subversion eclass, but the diff looks good.
>=20
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.

I've seen some projects that have a "anonymous" or "guest" user with a
trivial/documented password, so I guess it's for cases like those.


--=20
Fabian Groffen
Gentoo on a different level

--jwSnfOBD38i7UC9C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (Darwin)

iEUEARECAAYFAk9FKCcACgkQX3X2B8XHTone/gCeIfI/O/8N04KuCqlU1Jby1D3e
xZkAmNTmOdgOUaITm7buqYW00NHBxsM=
=6ZqW
-----END PGP SIGNATURE-----

--jwSnfOBD38i7UC9C--