From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Rskd7-0002qN-2G for garchives@archives.gentoo.org; Thu, 02 Feb 2012 00:34:25 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 01650E072D; Thu, 2 Feb 2012 00:34:13 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 0EA2EE05CB for ; Thu, 2 Feb 2012 00:33:38 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7A60D1B4013 for ; Thu, 2 Feb 2012 00:33:38 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] unpacker.eclass Date: Wed, 1 Feb 2012 19:33:54 -0500 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) References: <201202011505.41142.vapier@gentoo.org> <201202011555.46748.vapier@gentoo.org> <20120202001202.060d6925@pomiocik.lan> In-Reply-To: <20120202001202.060d6925@pomiocik.lan> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1452537.ZJAWMSuhLa"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201202011933.55289.vapier@gentoo.org> X-Archives-Salt: 4ea1d665-d861-40b9-b830-196c68183c74 X-Archives-Hash: 5eb30a0c69e8a73b7d38be6bbbe82ac6 --nextPart1452537.ZJAWMSuhLa Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 01 February 2012 18:12:02 Micha=C5=82 G=C3=B3rny wrote: > On Wed, 1 Feb 2012 15:55:46 -0500 Mike Frysinger wrote: > > On Wednesday 01 February 2012 15:51:52 Micha=C5=82 G=C3=B3rny wrote: > > > On Wed, 1 Feb 2012 15:44:14 -0500 Mike Frysinger wrote: > > > > > > # @USAGE: [archives that we will unpack] > > > > > > # @RETURN: Dependencies needed to unpack all the archives > > > > > > # @DESCRIPTION: > > > > > > # Walk all the specified files (defaults to $SRC_URI) and > > > > > > figure out the # dependencies that are needed to unpack > > > > > > things. # > > > > > > # Note: USE flags are not yet handled. > > > > > > unpacker_src_uri_depends() { > > > > > >=20 > > > > > > local uri deps d > > > > > > =09 > > > > > > [[ $# -eq 0 ]] && set -- ${SRC_URI} > > > > > > =09 > > > > > > for uri in "$@" ; do > > > > > > =09 > > > > > > case ${uri} in > > > > > > *.rar|*.RAR) > > > > > > =09 > > > > > > d=3D"app-arch/unrar" ;; > > > > > > =09 > > > > > > *.7z) > > > > > > =09 > > > > > > d=3D"app-arch/p7zip" ;; > > > > >=20 > > > > > Where are those file formats handled? You don't seem to > > > > > fallback to 'unpack' anywhere too. > > > >=20 > > > > eh ? this func doesn't do unpacking, just ${SRC_URI}<->${DEPEND} > > > > matching. > > >=20 > > > Sooo.. it's intended to generate an useless DEPEND > >=20 > > the ebuild does: > > DEPEND+=3D" $(unpacker_src_uri_depends)" > > =09 > > > or you have to reset src_unpack() to default to make the archives > > > actually extractable. > >=20 > > this func has nothing to do with extraction. look at the rest of the > > code to see how the default src_unpack is handled via standard > > EXPORT_FUNC means. >=20 > Yes, and can that exported default src_unpack() extract either .rar > or .7z? there are no plans for that since portage handles it from EAPI=3D0 onwards.= i=20 can have _unpacker() automatically tail off into `unpack` if it finds a fil= e it=20 doesn't recognize. =2Dmike --nextPart1452537.ZJAWMSuhLa Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPKdnzAAoJEEFjO5/oN/WB9VoQAL1Le5bM2vD2EJuxMGJ3CoC1 tXUL5Nnm3wWghmMOvrAe/VH6keJ5dT7EuIoH8kIxbNokRhVbcM5+VobwCMlhnuYO ThJ2T4ZoYaCDWn6bkuMB60HKdjRhcfjnXB6k39xu/wCfL2rwuStCXKwfOzzIhpoe 72f41duR9VpmVDyBWYdhXuxgNdljwBFD9jYIJUiFImcXb+nLsVbc7sBp7NdkMSf5 UsM2XsggyrxY1y/rUG9Y80UbYcjzgEXCkNN03coFFyqj4xYIBooc6HaIRzucGPrH GD5jNEXOCCLKKjS+b642L3x6KRrTnmvRI0hjsJFfkvLTCDnRJXmWVv0CrN5JVJUE nxEUeQYlmsedHm+A/z16OeObTXInCXSPKvxQ7qT+uPKul1d7Cl+NdX0gbHciCx1j utQifZZutRRI7LWHTtJCtCADHUowDJ2i47POtSHOmrYkkzEXcrSmFh0cfhXndGi3 yMz8jZnOzKursAFTfzqjWmq1c+KWXj4i8t+RGVoEajTzWAz8+n1ROyqk0m/J94KO SRn8ibvDaLWBjqEU2sXju+NEioTDz8K5beT7Gl4oR0wod8MZl+3z4ggs2imZCahJ 9egqGuH7XE0Ury7J9I0jFGHXFQy7i1HJF2yb/bXehG7//dxauGSi1hdn0DAqcUcU GiygcAKPIgWeWszg4uQG =ej1c -----END PGP SIGNATURE----- --nextPart1452537.ZJAWMSuhLa--