From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RshDv-0005OG-9l for garchives@archives.gentoo.org; Wed, 01 Feb 2012 20:56:11 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 69B1AE0863; Wed, 1 Feb 2012 20:55:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 9DAC1E07EC for ; Wed, 1 Feb 2012 20:55:31 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 1730D1B4006 for ; Wed, 1 Feb 2012 20:55:31 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] unpacker.eclass Date: Wed, 1 Feb 2012 15:55:46 -0500 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) References: <201202011505.41142.vapier@gentoo.org> <201202011544.14657.vapier@gentoo.org> <20120201215152.558e823c@pomiocik.lan> In-Reply-To: <20120201215152.558e823c@pomiocik.lan> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart10571255.mLgE9L2uDh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201202011555.46748.vapier@gentoo.org> X-Archives-Salt: bf5e3a30-fe31-4c67-9c3e-6c86fabd8982 X-Archives-Hash: 439e57dd94835de85f7a3836197dd75b --nextPart10571255.mLgE9L2uDh Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 01 February 2012 15:51:52 Micha=C5=82 G=C3=B3rny wrote: > On Wed, 1 Feb 2012 15:44:14 -0500 Mike Frysinger wrote: > > > > # @USAGE: [archives that we will unpack] > > > > # @RETURN: Dependencies needed to unpack all the archives > > > > # @DESCRIPTION: > > > > # Walk all the specified files (defaults to $SRC_URI) and figure > > > > out the # dependencies that are needed to unpack things. > > > > # > > > > # Note: USE flags are not yet handled. > > > > unpacker_src_uri_depends() { > > > >=20 > > > > local uri deps d > > > > =09 > > > > [[ $# -eq 0 ]] && set -- ${SRC_URI} > > > > =09 > > > > for uri in "$@" ; do > > > > =09 > > > > case ${uri} in > > > > *.rar|*.RAR) > > > > =09 > > > > d=3D"app-arch/unrar" ;; > > > > =09 > > > > *.7z) > > > > =09 > > > > d=3D"app-arch/p7zip" ;; > > >=20 > > > Where are those file formats handled? You don't seem to fallback to > > > 'unpack' anywhere too. > >=20 > > eh ? this func doesn't do unpacking, just ${SRC_URI}<->${DEPEND} > > matching. >=20 > Sooo.. it's intended to generate an useless DEPEND the ebuild does: DEPEND+=3D" $(unpacker_src_uri_depends)" > or you have to reset src_unpack() to default to make the archives actually > extractable. this func has nothing to do with extraction. look at the rest of the code = to=20 see how the default src_unpack is handled via standard EXPORT_FUNC means. =2Dmike --nextPart10571255.mLgE9L2uDh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPKabSAAoJEEFjO5/oN/WBtesQALiTch1RDLRSaDO6QIDfdHRm +N6cOqtgFTYSJxA/795zggKYSGFQOxj5o77YNh+/1FM/o3Bs1gTBK4IOuIWlWYth mVNxEeB4dBQ7dl2k0f0341XpmF1u4QXI0S3x0how6hppRgLPzb+Gy+hORMNfaN7X bLkWeFCpwyh4ksmLQ/1zN3qSHQHim6lehIuZeQuR6NmXIqpxqzrz/2zTkXJdmAEu XwnVW8Ntu/Y6f6XUG1HZLuNTezA0hGcv8UHJfIURFE6ywPYEIYv1H8M+2Fqw69Uj V1+PuTv7cBKge2m20+PyJv9hklRMHnQZY21kUy6Hoiq7KFafJXRYAaM2ZoVoV449 nfE1c9OVFVbHT/5YRjadBWBYThezXY02wxM9aWPJAEbQ7i7FWx7qMTEIRPOU21tk IN61MXIuIi3k6HVKpEjhvFZ8SlTs9TWYWOg2Dvs1Jg/ooS5t5KUS/kGd0qeurwGP ocCBIDhFc6jc187BpvLc7H0hA78Qg5FuwcxJ1UKHRhjTmoj/MzrBL2mKtvoSZjyZ j3xjW6R5huPwJeQwCOTAjLPSwjdis2Xxd5Vukpb+cbRDMrSypcwgHYURxPt5mcww m7lrHR+QUY5FqbUFpuVUGMXjGBWtfEPY6bQGUD2GhFHlI0YR6YkHWepiPhGlLVHl qS+f2RbAOaoZGeD5ziXM =qIyB -----END PGP SIGNATURE----- --nextPart10571255.mLgE9L2uDh--