Re: [gentoo-dev] unpacker.eclass

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1402 bytes --]

On Wednesday 01 February 2012 15:51:52 Michał Górny wrote:
> On Wed, 1 Feb 2012 15:44:14 -0500 Mike Frysinger wrote:
> > > > # @USAGE: [archives that we will unpack]
> > > > # @RETURN: Dependencies needed to unpack all the archives
> > > > # @DESCRIPTION:
> > > > # Walk all the specified files (defaults to $SRC_URI) and figure
> > > > out the # dependencies that are needed to unpack things.
> > > > #
> > > > # Note: USE flags are not yet handled.
> > > > unpacker_src_uri_depends() {
> > > > 
> > > > 	local uri deps d
> > > > 	
> > > > 	[[ $# -eq 0 ]] && set -- ${SRC_URI}
> > > > 	
> > > > 	for uri in "$@" ; do
> > > > 	
> > > > 		case ${uri} in
> > > > 		*.rar|*.RAR)
> > > > 		
> > > > 			d="app-arch/unrar" ;;
> > > > 		
> > > > 		*.7z)
> > > > 		
> > > > 			d="app-arch/p7zip" ;;
> > > 
> > > Where are those file formats handled? You don't seem to fallback to
> > > 'unpack' anywhere too.
> > 
> > eh ?  this func doesn't do unpacking, just ${SRC_URI}<->${DEPEND}
> > matching.
> 
> Sooo.. it's intended to generate an useless DEPEND

the ebuild does:
	DEPEND+=" $(unpacker_src_uri_depends)"

> or you have to reset src_unpack() to default to make the archives actually
> extractable.

this func has nothing to do with extraction.  look at the rest of the code to 
see how the default src_unpack is handled via standard EXPORT_FUNC means.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]