public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass
Date: Wed, 18 Jan 2012 06:57:58 -0500	[thread overview]
Message-ID: <201201180657.59189.vapier@gentoo.org> (raw)
In-Reply-To: <20246.45303.883949.499162@a1i15.kph.uni-mainz.de>

[-- Attachment #1: Type: Text/Plain, Size: 547 bytes --]

On Wednesday 18 January 2012 06:45:59 Ulrich Mueller wrote:
> >>>>> On Wed, 18 Jan 2012, Mike Frysinger wrote:
> > ebuild:
> > CDROM_OPTIONAL="yes"
> > inherit cdrom
> > 
> > eclass:
> > if [[ ${CDROM_OPTIONAL} == "yes" ]] ; then
> > 	PROPERTIES="cdinstall? ( interactive )"
> > else
> > 	PROPERTIES="interactive"
> > fi
> > IUSE="cdinstall"
> 
> Looks good, except that I would move the IUSE line into the "then"
> clause.

err, yeah.  i'll commit this proposal so you don't have to be on the hook for 
the breakage ;).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-01-18 11:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120113223516.8AC8F2004B@flycatcher.gentoo.org>
2012-01-13 23:36 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass Markos Chandras
2012-01-14  6:53   ` "Paweł Hajdan, Jr."
2012-01-14 11:21     ` Ulrich Mueller
2012-01-14 14:22       ` "Paweł Hajdan, Jr."
2012-01-14 14:26         ` Michael Sterrett
2012-01-14 16:03           ` Ulrich Mueller
2012-01-18 11:26             ` Mike Frysinger
2012-01-18 11:45               ` Ulrich Mueller
2012-01-18 11:57                 ` Mike Frysinger [this message]
2012-01-14 10:15   ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201180657.59189.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox