From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-48809-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1RVqpJ-0002Q2-Vj
	for garchives@archives.gentoo.org; Wed, 30 Nov 2011 20:32:22 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 583B421C11E;
	Wed, 30 Nov 2011 20:32:02 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 7B7AD21C10F
	for <gentoo-dev@lists.gentoo.org>; Wed, 30 Nov 2011 20:31:15 +0000 (UTC)
Received: from vapier.localnet (localhost [127.0.0.1])
	by smtp.gentoo.org (Postfix) with ESMTP id BD3BF1B400A;
	Wed, 30 Nov 2011 20:31:14 +0000 (UTC)
From: Mike Frysinger <vapier@gentoo.org>
Organization: wh0rd.org
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/
Date: Wed, 30 Nov 2011 15:31:14 -0500
User-Agent: KMail/1.13.7 (Linux/3.1.0; KDE/4.6.5; x86_64; ; )
Cc: Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org>
References: <1d4ac47c28706094230cb2c4e6ee1c1c71629aa0.arfrever@gentoo> <20111126105822.GA37825@gentoo.org> <201111272329.02491.Arfrever@gentoo.org>
In-Reply-To: <201111272329.02491.Arfrever@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart4612267.B4BLfE8KxD";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201111301531.14947.vapier@gentoo.org>
X-Archives-Salt: fd16be33-08d6-4502-9022-c1d742f0b020
X-Archives-Hash: 0ce62975be0fbefe8078711ba1098f00

--nextPart4612267.B4BLfE8KxD
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sunday 27 November 2011 17:28:12 Arfrever Frehtes Taifersar Arahesis wro=
te:
> 2011-11-26 11:58:22 Fabian Groffen napisa=C5=82(a):
> > On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
> > > commit:     1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
> > > T> Org>
> > > AuthorDate: Sat Nov 26 01:52:49 2011 +0000
> > > Commit:     Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo
> > > <DOT> org> CommitDate: Sat Nov 26 01:52:49 2011 +0000
> > > URL:      =20
> > > http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dcommi=
t;h=3D1
> > > d4ac47c
> > >=20
> > > dblink.mergeme(): Merge files in alphabetic order.
> >=20
> > What's the advantage of this?
>=20
> The advantage is that this allows to easier review output of `emerge` to
> verify if correct files have been installed.

then you should be sorting the output and not the db

along these lines, if you're going to be making commits to important repos,=
=20
please use changelogs that are actually useful.  the changelog here:
	dblink.mergeme(): Merge files in alphabetic order.
is utterly and completely useless.

you need to document *why* you're changing things first and foremost, and o=
nly=20
then can you delve into details as to why the implementation you're committ=
ing=20
makes sense.
=2Dmike

--nextPart4612267.B4BLfE8KxD
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAABAgAGBQJO1pKSAAoJEEFjO5/oN/WBcdwQANxibc4rTCfw7o7aqipMWM2t
bPaIXwLHSTEpCHyVJ1rx5gUcRKcnHaqn2maFJuHVb4n4jevJbf6t5nwrU/3Fg4CR
7fwbfAHEQ0eqj8Sje9AmQtWr5dhDeIHhdL1J7WQABEwxuyJKL+MoN9cTUimK3I+w
if6ALFu3VB3oFawJljaHhJ9xVhIJRZAiDor7D1ZLeiZ5D3CA9ktwr/AzYMPff2QG
MlBSgzxGnCQaco0LKNGGYWtPKKabIOkiu8923HnHKWw8vq3mWlIJwb6c22s9Ttc1
q7p6miyJiNKUJt+XS1XIpsBKK+lNlHiHq3fVcPpdtdMrEa2UUBT47GPfqH/JxH2L
sTmiQqCm7e2tuYYEQ2KLCpEkG3CP+is0Kf8vmd6o3OGmTqOGA93ovACRE6FYT76f
tfK+wluKnYnZF1I0iIokM1sgeeWgoQhEtrb1ZI+v1lSn1r7Z3e2/HFQQEZ3FhKGR
x4YhiSjnmylJIq8D6ToBB91iquF4IgfX2NiJgL8uyE7DNbz+kOTqA+KDn+a8DVxB
HXDz+Q0iRMjl2HyoOPT7/KDojThLTNg4sCqjNptfDQDhuWOfaFHYsTToQ3EL4m5u
jVuHeJE204aTpO0tViiz3Sz+BeDbJCa9UfggqhSXc+cn7VasPzw8v3cPgt55wUlV
o3LAnG2+op0DAihyq9KV
=jdx7
-----END PGP SIGNATURE-----

--nextPart4612267.B4BLfE8KxD--