From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RUFyL-0000Uy-5B for garchives@archives.gentoo.org; Sat, 26 Nov 2011 10:59:05 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 870F821C0DB; Sat, 26 Nov 2011 10:58:51 +0000 (UTC) Received: from amun.cheops.ods.org (amun.cheops.ods.org [83.161.135.166]) by pigeon.gentoo.org (Postfix) with ESMTP id ADC6921C07D for ; Sat, 26 Nov 2011 10:58:25 +0000 (UTC) Received: from nut.cheops.ods.org ([2001:888:1022:0:ca2a:14ff:fe35:7a00] helo=gentoo.org) by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.77) (envelope-from ) id 1RUFxf-0002PH-AP; Sat, 26 Nov 2011 11:58:24 +0100 Date: Sat, 26 Nov 2011 11:58:22 +0100 From: Fabian Groffen To: gentoo-dev@lists.gentoo.org, Arfrever Frehtes Taifersar Arahesis Subject: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/ Message-ID: <20111126105822.GA37825@gentoo.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org, Arfrever Frehtes Taifersar Arahesis References: <1d4ac47c28706094230cb2c4e6ee1c1c71629aa0.arfrever@gentoo> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <1d4ac47c28706094230cb2c4e6ee1c1c71629aa0.arfrever@gentoo> User-Agent: Mutt/1.5.21 (Darwin 11.2.0, VIM - Vi IMproved 7.3) Organization: Gentoo Foundation, Inc. X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV X-Archives-Salt: 4c94a673-00f0-49f3-9f2c-1cce5b3de132 X-Archives-Hash: d69169732998811bfbbcd42693d3a5a5 --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Attempt 2 from correct email address, sorry for any duplicate in advance. On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote: > commit: 1d4ac47c28706094230cb2c4e6ee1c1c71629aa0 > T> Org> > AuthorDate: Sat Nov 26 01:52:49 2011 +0000 > Commit: Arfrever Frehtes Taifersar Arahesis gentoo org> > CommitDate: Sat Nov 26 01:52:49 2011 +0000 > URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3D1d4ac47c >=20 > dblink.mergeme(): Merge files in alphabetic order. What's the advantage of this? I don't really like to pay for sorting a potentially huge list just for some eye-candy. (That's omitted by default these days anyway...) Any other opinions on this one? > --- > pym/portage/dbapi/vartree.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py > index dd74c10..099164a 100644 > --- a/pym/portage/dbapi/vartree.py > +++ b/pym/portage/dbapi/vartree.py > @@ -3981,7 +3981,7 @@ class dblink(object): > mergelist =3D stufftomerge > offset =3D "" > =20 > - for i, x in enumerate(mergelist): > + for i, x in enumerate(sorted(mergelist)): > =20 > mysrc =3D join(srcroot, offset, x) > mydest =3D join(destroot, offset, x) >=20 --=20 Fabian Groffen Gentoo on a different level --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (Darwin) iEYEARECAAYFAk7Qxk4ACgkQX3X2B8XHTond2QCfUVkQ2bweT30rapeBjU4qaNpJ 0dcAoJ6+3ShqnmabVMcKmLNI807KAz7O =Zcwm -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--