public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] enew{user,group}: killing off [extra] argument
Date: Wed, 2 Nov 2011 18:13:11 -0400	[thread overview]
Message-ID: <201111021813.11725.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

when i first wrote enew{user,group} oh-so-long-ago, the reason for the [extra] 
arguments was the assumption that i am short sighted.  i figured someone would 
come up with some creative need for passing additional flags that i couldn't 
possibly think of.

however, in the ~9 years since, all i have to report is disappointment in the 
collective lack of creativity when it comes to abusing open ended interfaces.  
two flags have surfaced in the main tree with enewuser, and only in a handful 
of ebuilds:
	-c <comment>
	-G <groups>
enewgroup hasn't had any extra args !

when it comes to -c, the custom comment in the ebuilds isn't all that better 
than the default one that enewuser already adds, so i've punted them.

when it comes to -G, it's a matter of the existing argument not being 
correctly utilized.  enewuser already takes care of splitting the <groups> 
argument into -g/-G.  so i've converted the packages using this.

back to the point of this e-mail ... i plan on dropping the [extra] part of 
enew{user,group} and changing this to a `die`.  this simplifies the interface, 
and makes it more portable -- the darwin port has already been calling `die` 
when people pass in extra args.

now is the time to whine if you want to keep this !
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2011-11-02 22:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 22:13 Mike Frysinger [this message]
2011-11-03 15:30 ` [gentoo-dev] enew{user,group}: killing off [extra] argument Mike Frysinger
2011-11-06 18:33   ` Petteri Räty
2011-11-06 22:54     ` Mike Frysinger
2011-11-09 21:24       ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111021813.11725.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox