From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RIk1P-0001Ex-9i for garchives@archives.gentoo.org; Tue, 25 Oct 2011 16:38:39 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5054621C043; Tue, 25 Oct 2011 16:38:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 46D99E07F7 for ; Tue, 25 Oct 2011 16:37:56 +0000 (UTC) Received: from pomiocik.lan (77-253-197-42.adsl.inetia.pl [77.253.197.42]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 7AB401B4023; Tue, 25 Oct 2011 16:37:53 +0000 (UTC) Date: Tue, 25 Oct 2011 18:37:49 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: vapier@gentoo.org Subject: Re: [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs. Message-ID: <20111025183749.7816b717@pomiocik.lan> In-Reply-To: References: <1319394037-4619-1-git-send-email-mgorny@gentoo.org> <20111024034223.GX22488@ohnopublishing.net> <20111024094654.3699c247@pomiocik.lan> Organization: Gentoo X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/fGEnmfLQ70zH+gIAKu1vVsW"; protocol="application/pgp-signature" X-Archives-Salt: X-Archives-Hash: ab01fe7584d87ffcba0d61ab34c8b39d --Sig_/fGEnmfLQ70zH+gIAKu1vVsW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 25 Oct 2011 01:57:11 -0400 Mike Frysinger wrote: > On Mon, Oct 24, 2011 at 03:46, Micha=C5=82 G=C3=B3rny wrote: > > On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote: > >> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: > >> > --- > >> > =C2=A0scons-utils.eclass | =C2=A0 33 +++++++++++++++++++++++++------= -- > >> > =C2=A01 files changed, 25 insertions(+), 8 deletions(-) > >> ... > >> > +# @ECLASS-VARIABLE: myesconsargs > >> > +# @DEFAULT_UNSET > >> > +# @DESCRIPTION: > >> > +# List of package-specific options to pass to all SCons calls. > >> > Supposed to be +# set in src_configure(). > >> > >> Shouldn't this variable be named MYESCONSARGS since it is being > >> introduced into the global scope? > > > > I can't deny that but I'd like to keep it consistent with > > cmake-utils and autotools-utils. Alternate approach would be to > > make it local to src_configure() and add > > scons-utils_src_configure() which would export it under internal > > name but I don't think that's really worth the effort. >=20 > sounds like you want @VARIABLE and not @ECLASS-VARIABLE Thanks, fixed. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/fGEnmfLQ70zH+gIAKu1vVsW Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iJwEAQEIAAYFAk6m5eIACgkQfXuS5UK5QB19WgQAmbrrdwSp75ems5gXKFN7Y9sU 4rRKqAZ3UU3B0+lqpVhOLAnbFf1UUPANaHpOr8JZjO/itMewUWLFxPpHcEKStmcz GZyMXnmpB1Nu6igwRu9eFqeJpcTgfV9UjaSRVFSX8UMPgM3ZfWzJXTMqfMpGkREu iqKuHsFORcdmffA8WSY= =Z5Pm -----END PGP SIGNATURE----- --Sig_/fGEnmfLQ70zH+gIAKu1vVsW--