From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RIFGM-0000pk-4Z for garchives@archives.gentoo.org; Mon, 24 Oct 2011 07:48:02 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0035F21C04B; Mon, 24 Oct 2011 07:47:42 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 2472821C025 for ; Mon, 24 Oct 2011 07:46:58 +0000 (UTC) Received: from pomiocik.lan (77-253-197-42.adsl.inetia.pl [77.253.197.42]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 64E5B1B4009; Mon, 24 Oct 2011 07:46:56 +0000 (UTC) Date: Mon, 24 Oct 2011 09:46:54 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: binki@gentoo.org Subject: Re: [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs. Message-ID: <20111024094654.3699c247@pomiocik.lan> In-Reply-To: <20111024034223.GX22488@ohnopublishing.net> References: <1319394037-4619-1-git-send-email-mgorny@gentoo.org> <20111024034223.GX22488@ohnopublishing.net> Organization: Gentoo X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/RQVBR_CYNikN9KRqAcKsP_U"; protocol="application/pgp-signature" X-Archives-Salt: X-Archives-Hash: ae28ce7a8f195e209ea352c78ca4d472 --Sig_/RQVBR_CYNikN9KRqAcKsP_U Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote: > On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: > > --- > > scons-utils.eclass | 33 +++++++++++++++++++++++++-------- > > 1 files changed, 25 insertions(+), 8 deletions(-) > ... > > +# @ECLASS-VARIABLE: myesconsargs > > +# @DEFAULT_UNSET > > +# @DESCRIPTION: > > +# List of package-specific options to pass to all SCons calls. > > Supposed to be +# set in src_configure(). >=20 > Shouldn't this variable be named MYESCONSARGS since it is being > introduced into the global scope? I can't deny that but I'd like to keep it consistent with cmake-utils and autotools-utils. Alternate approach would be to make it local to src_configure() and add scons-utils_src_configure() which would export it under internal name but I don't think that's really worth the effort. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/RQVBR_CYNikN9KRqAcKsP_U Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iJwEAQEIAAYFAk6lF/MACgkQfXuS5UK5QB2W9QQAl+F7fDWwPiKzCrqv90pGf+HO SKGk7Y28OTsXKMZecoL+IN6t8P/b4YkH7gN5AFbVjg6s4flJWEHOqBTxTHFvtHTw SE6k6vU4Cxh0cHZpnZfJxKWZ7eFFrZOk/9buG2LkoCl08kyPiPjYJTCe5zx0oLNX PTM+ATiYaXWZ6ywG4xg= =lzci -----END PGP SIGNATURE----- --Sig_/RQVBR_CYNikN9KRqAcKsP_U--