From: Nathan Phillip Brink <binki@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs.
Date: Mon, 24 Oct 2011 03:42:24 +0000 [thread overview]
Message-ID: <20111024034223.GX22488@ohnopublishing.net> (raw)
In-Reply-To: <1319394037-4619-1-git-send-email-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote:
> ---
> scons-utils.eclass | 33 +++++++++++++++++++++++++--------
> 1 files changed, 25 insertions(+), 8 deletions(-)
...
> +# @ECLASS-VARIABLE: myesconsargs
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# List of package-specific options to pass to all SCons calls. Supposed to be
> +# set in src_configure().
Shouldn't this variable be named MYESCONSARGS since it is being
introduced into the global scope?
--
binki
Look out for missing or extraneous apostrophes!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-10-24 3:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 18:20 [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs Michał Górny
2011-10-24 3:42 ` Nathan Phillip Brink [this message]
2011-10-24 7:46 ` Michał Górny
2011-10-25 5:57 ` Mike Frysinger
2011-10-25 16:37 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024034223.GX22488@ohnopublishing.net \
--to=binki@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox