From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1REjxg-0000bE-E0 for garchives@archives.gentoo.org; Fri, 14 Oct 2011 15:46:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B704C21C0D0; Fri, 14 Oct 2011 15:46:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 0649C21C093 for ; Fri, 14 Oct 2011 15:45:10 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7BC891B401C for ; Fri, 14 Oct 2011 15:45:10 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] new helper: econf_build Date: Fri, 14 Oct 2011 11:45:09 -0400 User-Agent: KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) References: <201110131948.00897.vapier@gentoo.org> <4E97DFDE.1000000@gentoo.org> In-Reply-To: <4E97DFDE.1000000@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1329387.X3PJfhqpjs"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201110141145.10058.vapier@gentoo.org> X-Archives-Salt: X-Archives-Hash: 27ab597187d29443be7bb6f98f1b65bf --nextPart1329387.X3PJfhqpjs Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Friday 14 October 2011 03:08:14 Michael Haubenwallner wrote: > On 10/14/11 01:48, Mike Frysinger wrote: > > i've found myself a few times having to implement logic like so: > > CFLAGS=3D${BUILD_CFLAGS:--O1 -pipe} \ > > CXXFLAGS=3D${BUILD_CXXFLAGS:--O1 -pipe} \ > > CPPFLAGS=3D${BUILD_CPPFLAGS} \ > > LDFLAGS=3D${BUILD_LDFLAGS} \ > > CC=3D$(tc-getBUILD_CC) \ > > LD=3D$(tc-getBUILD_LD) \ > > econf --host=3D${CBUILD} "$@" >=20 > >=20 > > so rather than continuing to copy & paste this logic everywhere, i'm > > going to add it to toolchain-funcs.eclass as "econf_build". any > > feedback before i do ? >=20 > Eventually not to stick to 'econf', but provide a more generic one, > so it is useable like this (in lack of a better name): >=20 > run_with_build_env econf --host=3D${CBUILD} ... i thought of that, but it seems like we've generally moved away from this=20 style in the tree. the biggest example being `try ...` -> `... || die`. i'll probably implement as an @INTERNAL: tc-env_build() { ... } then define econf_build on top of that as an exported API. then let's see = what=20 grows organically beyond. =2Dmike --nextPart1329387.X3PJfhqpjs Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOmFkGAAoJEEFjO5/oN/WBYM0QANzPwj5DR8frK6HMht7tKKxn z2uuBIBD8G/8tqCZkBIFc2bLZhg22gm6AJ/H74zECIPZKHx+8d5ic639dC893vMB JzgCEfwAPwHm+q6arv3WA2YBdZOI4SAZiI8PfUgUc0pKhUVOQnEgicyn0zmYZxSs TnhVhopKUSGvn0bFJlNfmR3OyHcd75aZ/hexpvSUsJpNr2PZfSvhaNevc5SzcGHn tzuUF/cgh2ua/Nv3AouobNS2RyrkssMWXiUrFAj7FJwAbsmwvzxRAPR8UDgcB+Kd gwOjuaeY0U9IcTp0fq1IoEXp9bxYVlZBTqQdfHE1eEhaIcKjguAqrBMWHPJaGPAW vS1bJ+CAMXgoqqh2cyI10G63NVXUrUpEFZpjG/xScMPPPhrHPlIAeR2ZU3Rlp3gC obKuwoFFgnY/TXA7Rzt7/MdVMeMJAaQqRzbvJUlmvx8H5MIZNtxbgyF457/Zg/YO z12ynPQBsO7X1fHeOFhjoBXaSMvHS7myuE2Mqu+hpB4+74Mpbyn/+CHzziMFx6RD 7VkhPRSX6oXN5Szw0b3mmntIuKFgk0tt9DNkZ0o6KxtGhL1PQgI5OW+lCLtz5Fjm eOZ2UGKXqv9AUO11inSfhpKQd33Q6LfJzwKGDGw6VGjbG1C0OPBxjl8vIDTCrmmA O0h57adyjuzc3M78FTKl =QJAH -----END PGP SIGNATURE----- --nextPart1329387.X3PJfhqpjs--