[gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[Michał Górny]

We're calling it with '--patch-only' to avoid heavy changes to ebuilds.
This should handle gracefully eautoreconfed packages and those not using
libtool as well (in worst case, it should try to apply patches twice).
---
 autotools-utils.eclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/autotools-utils.eclass b/autotools-utils.eclass
index bae95a1..b9655c8 100644
--- a/autotools-utils.eclass
+++ b/autotools-utils.eclass
@@ -89,7 +89,7 @@ case ${EAPI:-0} in
 	*) die "EAPI=${EAPI} is not supported" ;;
 esac
 
-inherit autotools base eutils
+inherit autotools base eutils libtool
 
 EXPORT_FUNCTIONS src_prepare src_configure src_compile src_install src_test
 
@@ -212,6 +212,7 @@ autotools-utils_src_prepare() {
 	debug-print-function ${FUNCNAME} "$@"
 
 	base_src_prepare
+	elibtoolize --patch-only
 }
 
 # @FUNCTION: autotools-utils_src_configure
-- 
1.7.7

Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On 10:21 Sun 09 Oct     , Michał Górny wrote:
> We're calling it with '--patch-only' to avoid heavy changes to ebuilds.
> This should handle gracefully eautoreconfed packages and those not using
> libtool as well (in worst case, it should try to apply patches twice).

What kind of testing have you done?

-- 
Thanks,
Donnie

Donnie Berkholz
Council Member / Sr. Developer
Gentoo Linux
Blog: http://dberkholz.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Sun, 9 Oct 2011 21:08:43 -0500
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> On 10:21 Sun 09 Oct     , Michał Górny wrote:
> > We're calling it with '--patch-only' to avoid heavy changes to
> > ebuilds. This should handle gracefully eautoreconfed packages and
> > those not using libtool as well (in worst case, it should try to
> > apply patches twice).
> 
> What kind of testing have you done?

Simple testing on a few packages of mine. If you have something
specific in mind, please be more accurate.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On 09:55 Mon 10 Oct     , Michał Górny wrote:
> On Sun, 9 Oct 2011 21:08:43 -0500
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > On 10:21 Sun 09 Oct     , Michał Górny wrote:
> > > We're calling it with '--patch-only' to avoid heavy changes to 
> > > ebuilds. This should handle gracefully eautoreconfed packages and 
> > > those not using libtool as well (in worst case, it should try to 
> > > apply patches twice).
> > 
> > What kind of testing have you done?
> 
> Simple testing on a few packages of mine. If you have something
> specific in mind, please be more accurate.

It's probably better to test on other people's code, since your own will 
always use eclass code in the way you imagine it being used. For changes 
to popular eclasses like this, I'd go find a cross-section of 25+ 
packages written by a variety of people besides yourself (or just test 
all 87 in the tree). Bonus points for those written by the most and 
least experienced devs, who I'd expect to use things in more 
unexpected/unlikely ways.

-- 
Thanks,
Donnie

Donnie Berkholz
Council Member / Sr. Developer
Gentoo Linux
Blog: http://dberkholz.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

On Mon, 10 Oct 2011 11:10:49 -0500
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> On 09:55 Mon 10 Oct     , Michał Górny wrote:
> > On Sun, 9 Oct 2011 21:08:43 -0500
> > Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > > On 10:21 Sun 09 Oct     , Michał Górny wrote:
> > > > We're calling it with '--patch-only' to avoid heavy changes to 
> > > > ebuilds. This should handle gracefully eautoreconfed packages
> > > > and those not using libtool as well (in worst case, it should
> > > > try to apply patches twice).
> > > 
> > > What kind of testing have you done?
> > 
> > Simple testing on a few packages of mine. If you have something
> > specific in mind, please be more accurate.
> 
> It's probably better to test on other people's code, since your own
> will always use eclass code in the way you imagine it being used. For
> changes to popular eclasses like this, I'd go find a cross-section of
> 25+ packages written by a variety of people besides yourself (or just
> test all 87 in the tree).

Yeah, I'm slowly testing random packages against it and haven't seen
any problems yet. Would be nice, though, to be able to let tinderbox do
the testing with modified eclasses.

> Bonus points for those written by the most
> and least experienced devs, who I'd expect to use things in more 
> unexpected/unlikely ways.

Sunrise seems a good choice here.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]