On Mon, 10 Oct 2011 11:10:49 -0500 Donnie Berkholz wrote: > On 09:55 Mon 10 Oct , Michał Górny wrote: > > On Sun, 9 Oct 2011 21:08:43 -0500 > > Donnie Berkholz wrote: > > > On 10:21 Sun 09 Oct , Michał Górny wrote: > > > > We're calling it with '--patch-only' to avoid heavy changes to > > > > ebuilds. This should handle gracefully eautoreconfed packages > > > > and those not using libtool as well (in worst case, it should > > > > try to apply patches twice). > > > > > > What kind of testing have you done? > > > > Simple testing on a few packages of mine. If you have something > > specific in mind, please be more accurate. > > It's probably better to test on other people's code, since your own > will always use eclass code in the way you imagine it being used. For > changes to popular eclasses like this, I'd go find a cross-section of > 25+ packages written by a variety of people besides yourself (or just > test all 87 in the tree). Yeah, I'm slowly testing random packages against it and haven't seen any problems yet. Would be nice, though, to be able to let tinderbox do the testing with modified eclasses. > Bonus points for those written by the most > and least experienced devs, who I'd expect to use things in more > unexpected/unlikely ways. Sunrise seems a good choice here. -- Best regards, Michał Górny