From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: dberkholz@gentoo.org
Subject: Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.
Date: Mon, 10 Oct 2011 18:38:48 +0200 [thread overview]
Message-ID: <20111010183848.5d365ed5@pomiocik.lan> (raw)
In-Reply-To: <20111010161049.GA4972@comet>
[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]
On Mon, 10 Oct 2011 11:10:49 -0500
Donnie Berkholz <dberkholz@gentoo.org> wrote:
> On 09:55 Mon 10 Oct , Michał Górny wrote:
> > On Sun, 9 Oct 2011 21:08:43 -0500
> > Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > > On 10:21 Sun 09 Oct , Michał Górny wrote:
> > > > We're calling it with '--patch-only' to avoid heavy changes to
> > > > ebuilds. This should handle gracefully eautoreconfed packages
> > > > and those not using libtool as well (in worst case, it should
> > > > try to apply patches twice).
> > >
> > > What kind of testing have you done?
> >
> > Simple testing on a few packages of mine. If you have something
> > specific in mind, please be more accurate.
>
> It's probably better to test on other people's code, since your own
> will always use eclass code in the way you imagine it being used. For
> changes to popular eclasses like this, I'd go find a cross-section of
> 25+ packages written by a variety of people besides yourself (or just
> test all 87 in the tree).
Yeah, I'm slowly testing random packages against it and haven't seen
any problems yet. Would be nice, though, to be able to let tinderbox do
the testing with modified eclasses.
> Bonus points for those written by the most
> and least experienced devs, who I'd expect to use things in more
> unexpected/unlikely ways.
Sunrise seems a good choice here.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
prev parent reply other threads:[~2011-10-10 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 8:21 [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic Michał Górny
2011-10-10 2:08 ` Donnie Berkholz
2011-10-10 7:55 ` Michał Górny
2011-10-10 16:10 ` Donnie Berkholz
2011-10-10 16:38 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010183848.5d365ed5@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=dberkholz@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox