From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: jlec@gentoo.org
Subject: Re: [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages
Date: Sun, 17 Jul 2011 11:16:14 +0200 [thread overview]
Message-ID: <20110717111614.66dc7d5a@pomiocik.lan> (raw)
In-Reply-To: <4E22A5E3.3090109@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Sun, 17 Jul 2011 11:05:39 +0200
justin <jlec@gentoo.org> wrote:
> Hi all,
>
> the following change has some bad effects on packages in the tree. I
> found it with a package having this inherit line
>
> inherit cmake-utils wxwidgets
>
> all cmake-utils_* function which have redundant phase definitions in
> base will not be executed.
>
> This change was not trivial. So either we need to revert it or really
> check the tree that nothing is broken.
Revert. The wxwidgets eclass is not really supposed to export phase
functions, I've seen packages in Sunrise using it along with
cmake-utils too. If someone wants user patches in their package, he/she
should inherit base directly and get phase funcs clean.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
next prev parent reply other threads:[~2011-07-17 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 9:05 [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages justin
2011-07-17 9:16 ` Michał Górny [this message]
2011-07-17 9:19 ` justin
2011-07-17 20:08 ` [gentoo-dev] " Ryan Hill
2011-07-20 9:38 ` Francesco Riosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110717111614.66dc7d5a@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=jlec@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox