From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Q78Ll-0001Sl-I8 for garchives@archives.gentoo.org; Tue, 05 Apr 2011 15:39:25 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C4A5F1C054; Tue, 5 Apr 2011 15:39:16 +0000 (UTC) Received: from mx10.schiffbauer.net (mx10.schiffbauer.net [188.40.110.137]) by pigeon.gentoo.org (Postfix) with ESMTP id 9781CE0521 for ; Tue, 5 Apr 2011 15:38:49 +0000 (UTC) Received: from [88.128.86.148] (port=58466 helo=bart) by mx10.schiffbauer.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1Q78L8-000336-KV for gentoo-dev@lists.gentoo.org; Tue, 05 Apr 2011 17:38:48 +0200 Received: by bart (sSMTP sendmail emulation); Tue, 05 Apr 2011 17:38:44 +0200 Date: Tue, 5 Apr 2011 17:38:44 +0200 From: Marc Schiffbauer To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] KDE4 eclasses review Message-ID: <20110405153843.GB16173@bart> References: <4D99F91D.6010108@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4D99F91D.6010108@gentoo.org> X-Operating-System: Linux 2.6.38-gentoo-r1 x86_64 X-Editor: vim vim-7.3.135 X-Homepage: http://www.links2linux.de User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: by ClamAV (http://www.clamav.org) X-Spam-Score: -3.1 X-Spam-Level: --- Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 6d155c9dd6894b769a8820ca91bf3c20 * Tom=E1=A8 Chv=E1tal schrieb am 04.04.11 um 19:00 Uhr: > Hi guys, > since we didn't do this for quite long time I would like kde4 eclasses > reviewed as whole rather than on patch basis (altho i attach the patche= s > for convenience too). >=20 > It is 2 years since we reviewed them last time fully on -dev so lets se= e > how much weird/useless logic we can find (more heads know more). >=20 > Remember: nitpick on everything cause this thing is used in quite a lot > ebuilds so we need it in top-notch shape :) >=20 > This update brings support for git since upstream is slowly moving to > git repos from SVN. Dropped support for eapi2. Usage of fdo/gnome > classes to update mime stuff. Most of the koffice code removed as being > obsoleted and various loads of whitespace stuff. >=20 > Cheers >=20 > Tom > # Copyright 1999-2010 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: $ >=20 > # @ECLASS: kde4-base.eclass > # @MAINTAINER: > # kde@gentoo.org > # @BLURB: This eclass provides functions for kde 4.X ebuilds > # @DESCRIPTION: > # The kde4-base.eclass provides support for building KDE4 based ebuilds > # and KDE4 applications. > # > # NOTE: KDE 4 ebuilds currently support EAPI "3". This will be reviewe= d > # over time as new EAPI versions are approved. >=20 > # @ECLASS-VARIABLE: VIRTUALX_REQUIRED > # @DESCRIPTION: > # For proper description see virtualx.eclass manpage. > # Here we redefine default value to be manual, if your package needs vi= rtualx > # for tests you should proceed with setting VIRTUALX_REQUIRED=3Dtest. > : ${VIRTUALX_REQUIRED:=3Dmanual} [...] >=20 > KDE_MINIMAL=3D"${KDE_MINIMAL:-4.4}" I'd suggest setting default for all variables the same way. I personally like the : {X:=3D"default"} approach best. : ${KDE_MINIMAL:=3D4.4}=20 -Marc --=20 8AAC 5F46 83B4 DB70 8317 3723 296C 6CCA 35A6 4134