From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-45205-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1Q781h-0007jL-UY
	for garchives@archives.gentoo.org; Tue, 05 Apr 2011 15:18:42 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 3D11A1C07C;
	Tue,  5 Apr 2011 15:18:33 +0000 (UTC)
Received: from mx10.schiffbauer.net (mx10.schiffbauer.net [188.40.110.137])
	by pigeon.gentoo.org (Postfix) with ESMTP id B08871C060
	for <gentoo-dev@lists.gentoo.org>; Tue,  5 Apr 2011 15:18:07 +0000 (UTC)
Received: from [88.128.86.148] (port=44662 helo=bart)
	by mx10.schiffbauer.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.72)
	(envelope-from <marc@schiffbauer.net>)
	id 1Q7815-0000DZ-Bh
	for gentoo-dev@lists.gentoo.org; Tue, 05 Apr 2011 17:18:06 +0200
Received: by bart (sSMTP sendmail emulation); Tue, 05 Apr 2011 17:18:01 +0200
Date: Tue, 5 Apr 2011 17:18:01 +0200
From: Marc Schiffbauer <marc@schiffbauer.net>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] git-2.eclass final review
Message-ID: <20110405151801.GA16173@bart>
References: <4D890F8D.4090706@gentoo.org>
 <AANLkTiky_tfyUE=t-PcWPa+Gu9aMgyacqmR09XTfmTb+@mail.gmail.com>
 <4D8924CD.8000404@gentoo.org>
 <AANLkTingeQcC+ZLw9G4W37-9pQ7rdAkmFsaRHDUcRvsj@mail.gmail.com>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <AANLkTingeQcC+ZLw9G4W37-9pQ7rdAkmFsaRHDUcRvsj@mail.gmail.com>
X-Operating-System: Linux 2.6.38-gentoo-r1 x86_64
X-Editor: vim vim-7.3.135
X-Homepage: http://www.links2linux.de
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Virus-Scanned: by ClamAV (http://www.clamav.org)
X-Spam-Score: -3.0
X-Spam-Level: ---
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 
X-Archives-Hash: 5facbafc660b367d008cb3cfef4ad1ee

* Mike Frysinger schrieb am 23.03.11 um 00:08 Uhr:
> 2011/3/22 Tom=E1=A8 Chv=E1tal:
> > Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
> >>> # @BLURB: This eclass provides functions for fetch and unpack git r=
epositories
> >>
> >> fetching/unpacking
> >
> > Yarp fixed.
>=20
> well, the fix broke the blurb.  it has to be on one line.
> # @BLURB: foo
>=20
> > EGIT_BRANCH=3D${x:-${EGIT_BRANCH:=3D${EGIT_MASTER}}}
> > EGIT_COMMIT=3D${x:-${EGIT_COMMIT:=3D${EGIT_BRANCH}}}
>=20
> doesnt make much sense to use :=3D ... it should be :-
>=20
> > [[ "$#" -ne 1 ]] && die "${FUNCNAME}: requires 1 argument (path)"
>=20
> quoting doesnt make much sense ... -ne compares an int, not a string

If using [[ you never need to quote anyway.

-Marc
--=20
8AAC 5F46 83B4 DB70 8317  3723 296C 6CCA 35A6 4134