From: Marc Schiffbauer <marc@schiffbauer.net>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] git-2.eclass final review
Date: Tue, 5 Apr 2011 17:18:01 +0200 [thread overview]
Message-ID: <20110405151801.GA16173@bart> (raw)
In-Reply-To: <AANLkTingeQcC+ZLw9G4W37-9pQ7rdAkmFsaRHDUcRvsj@mail.gmail.com>
* Mike Frysinger schrieb am 23.03.11 um 00:08 Uhr:
> 2011/3/22 Tomáš Chvátal:
> > Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
> >>> # @BLURB: This eclass provides functions for fetch and unpack git repositories
> >>
> >> fetching/unpacking
> >
> > Yarp fixed.
>
> well, the fix broke the blurb. it has to be on one line.
> # @BLURB: foo
>
> > EGIT_BRANCH=${x:-${EGIT_BRANCH:=${EGIT_MASTER}}}
> > EGIT_COMMIT=${x:-${EGIT_COMMIT:=${EGIT_BRANCH}}}
>
> doesnt make much sense to use := ... it should be :-
>
> > [[ "$#" -ne 1 ]] && die "${FUNCNAME}: requires 1 argument (path)"
>
> quoting doesnt make much sense ... -ne compares an int, not a string
If using [[ you never need to quote anyway.
-Marc
--
8AAC 5F46 83B4 DB70 8317 3723 296C 6CCA 35A6 4134
next prev parent reply other threads:[~2011-04-05 15:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 21:07 [gentoo-dev] git-2.eclass final review Tomáš Chvátal
2011-03-22 21:26 ` Mike Frysinger
2011-03-22 22:38 ` Tomáš Chvátal
2011-03-22 23:08 ` Mike Frysinger
2011-03-22 23:41 ` [gentoo-dev] " Ryan Hill
2011-03-22 23:45 ` Ryan Hill
2011-03-22 23:55 ` Mike Frysinger
2011-03-23 12:28 ` James Cloos
2011-03-23 13:01 ` Tomáš Chvátal
2011-03-23 14:44 ` James Cloos
2011-03-24 12:54 ` Donnie Berkholz
2011-03-23 16:29 ` Donnie Berkholz
2011-03-24 10:52 ` James Cloos
2011-03-23 0:42 ` [gentoo-dev] " Tomáš Chvátal
2011-03-31 4:55 ` Jeroen Roovers
2011-03-31 6:32 ` Tomáš Chvátal
2011-03-31 7:29 ` Fabian Groffen
2011-03-31 16:00 ` Matt Turner
2011-03-31 21:23 ` Aaron W. Swenson
2011-04-05 15:18 ` Marc Schiffbauer [this message]
2011-04-17 8:44 ` [gentoo-dev] " Tomá? Chvátal
2011-04-17 18:31 ` James Cloos
2011-04-18 9:45 ` Tomáš Chvátal
2011-04-18 17:55 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405151801.GA16173@bart \
--to=marc@schiffbauer.net \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox