From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Q6iHi-000422-At for garchives@archives.gentoo.org; Mon, 04 Apr 2011 11:49:30 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2F1BEE05AF; Mon, 4 Apr 2011 11:49:21 +0000 (UTC) Received: from mail-pv0-f181.google.com (mail-pv0-f181.google.com [74.125.83.181]) by pigeon.gentoo.org (Postfix) with ESMTP id F1FA0E0587 for ; Mon, 4 Apr 2011 11:48:48 +0000 (UTC) Received: by pvg13 with SMTP id 13so2108997pvg.40 for ; Mon, 04 Apr 2011 04:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=DxsGRDovJKZjBq5fJKvlRqeOEsfqYPSK2wlPVpIOedE=; b=ZXeDUfj6MzL0SLhzk5R0WhSE9d7rN2Bx/Ehe+wl7qLMnKnEkCyUQgoAV1zdKwVRKH5 ziZe9cM7N+W6QyBeYuMnQV5B+1fk41sgZtjcUcqEeg86syW6K32Qi3pg+W9lHjKKd5cm o1YS+geXvYGflTKmI4Z4vQBJ1o8rsqkaX0pHI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=cwdGtZKqAUx719JTsY+fmyoGKdLfYppf4n+KrwvmbEnXHnexwq+lwjdNwYViDItohW EiMnjA04uZnF/2I4h1OGbTdISsTFsBb7Ed/lFyF4y4qsZVjQlXq5VASBkFhnsBqywcCM Wmw0EXPGkyJU5NAK674v4dkta5QkhBYdppb8A= Received: by 10.142.132.3 with SMTP id f3mr6218482wfd.36.1301917728323; Mon, 04 Apr 2011 04:48:48 -0700 (PDT) Received: from smtp.gmail.com (c-24-20-36-83.hsd1.wa.comcast.net [24.20.36.83]) by mx.google.com with ESMTPS id w32sm7473915wfh.19.2011.04.04.04.48.44 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Apr 2011 04:48:46 -0700 (PDT) Received: by smtp.gmail.com (sSMTP sendmail emulation); Mon, 04 Apr 2011 04:48:43 -0700 Date: Mon, 4 Apr 2011 04:48:43 -0700 From: Brian Harring To: gentoo-dev@lists.gentoo.org Cc: qa@gentoo.org Subject: Re: [gentoo-dev] python-namespaces.eclass Message-ID: <20110404114843.GA13291@hrair> References: <201104031938.18311.Arfrever@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: <201104031938.18311.Arfrever@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: X-Archives-Hash: e21fd66d9c3f53f3bc2a39de17d82a61 --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 03, 2011 at 07:38:17PM +0200, Arfrever Frehtes Taifersar Arahes= is wrote: > I would like to add python-namespaces.eclass. This eclass will be used by= a small number of > special packages, which will provide Python namespaces. These packages wi= ll be used as > dependencies of other packages already present in the tree. >=20 > Ebuilds using this eclass must set PYTHON_NAMESPACES variable before inhe= riting this eclass. > Example (from net-zope/namespaces-zope): namespaces-zope's invocation of the mod_optimize/cleanup crap isn't=20 needed since it's EAPI>=3D3; EAPI3 preserves mtime. What other consumers are expected for this beyond namespaces-zope? > PYTHON_NAMESPACES=3D"Products Shared Shared.DC five +zope zope.app" >=20 > This eclass provides 3 public functions: > python-namespaces_src_install() > python-namespaces_pkg_postinst() > python-namespaces_pkg_postrm() >=20 > --=20 > Arfrever Frehtes Taifersar Arahesis > > # Copyright 1999-2011 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: $ >=20 > # @ECLASS: python-namespaces.eclass > # @MAINTAINER: > # Gentoo Python Project > # @BLURB: Eclass for packages installing Python namespaces > # @DESCRIPTION: > # The python-namespaces eclass defines phase functions for packages insta= lling Python namespaces. ^^^ This isn't a useful description. What is it doing to the phase=20 functions? What's the purpose for someone who isn't intimately=20 familiar w/ python setuptools/namespaces? Etc. Seriously, I just spent a good 10 minutes digging through this crap=20 trying to figure out what you were up to- that is *exactly* what the=20 description should convey. Same goes for the code; this needs to be peppered with=20 clear/descriptive comments. The description for PYTHON_NAMESPACES for=20 example on it's own doesn't make clear that it screws with=20 REQUIRED_USE (let alone exactly it's intent). General commentary: If you want to do magic like this, it needs to be=20 documented clearly so everyone else can figure out wtf it is exactly=20 intending on doing (including what it actually is doing)- if it can't=20 be documented to that level it doesn't belong in the tree, only in=20 your personal overlay. As mentioned by others, if you're going to use [[ ]] stop doing unnecessarily quoting w/ that construct- fix your editor if it=20 doesn't color it correctly. ~harring --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iEYEARECAAYFAk2ZsBsACgkQsiLx3HvNzge+5wCeKmocWuz3pL5jFyEwyaFB/dDM NeYAnj3wvHv70DPTYTJJ/3R9xD4v9Fdt =6SjP -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--